Skip to content

Deprecate cfgrib backend #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
headtr1ck opened this issue Oct 23, 2022 · 4 comments · Fixed by #7670
Closed

Deprecate cfgrib backend #7199

headtr1ck opened this issue Oct 23, 2022 · 4 comments · Fixed by #7670
Labels
dependencies Pull requests that update a dependency file needs discussion topic-backends

Comments

@headtr1ck
Copy link
Collaborator

What is your issue?

Since cfgrib 0.9.9 (04/2021) it comes with its own xarray backend plugin (looks mainly like a copy of our internal version).
We should deprecate our internal plugin.

The deprecation is complicated since we usually bind the minimum version to a minor step, but cfgrib seems to be on 0.9 since 4 years already. Maybye an exception like for netCDF4?

Anyway, if we decide to leave it as it is for now, this ticket is just a reminder to remove it someday :)

@headtr1ck headtr1ck added topic-backends needs discussion dependencies Pull requests that update a dependency file labels Oct 23, 2022
@dcherian
Copy link
Contributor

cc @alexamici

@headtr1ck
Copy link
Collaborator Author

Any ideas on how to deprecate this?
Do we raise a Deprecation warning if someone uses the open_dataset method of the internal backend?
And then remove it some versions down the line?

@dcherian
Copy link
Contributor

cc @alexamici

@alexamici
Copy link
Collaborator

@dcherian note that cfgrib is now maintained by @iainrussell, anyway I agree that the in-tree driver can be safely removed.

@headtr1ck I don't think any deprecation is needed, the engine="cfgrib" should select the external backend if available and fall back on the internal one only for ancient versions of cfgrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs discussion topic-backends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants