Skip to content

Commit 0a4cbc1

Browse files
committed
Improve test coverage
1 parent cdd7400 commit 0a4cbc1

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed

pyexcel_io/book.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,10 @@ def write(self, incoming_dict):
164164
sheet_writer.close()
165165

166166
def create_sheet(self, sheet_name):
167-
pass
167+
"""
168+
implement this method for easy extension
169+
"""
170+
raise NotImplementedError("Please implement create_sheet()")
168171

169172

170173
def _convert_content_to_stream(file_content, file_type):

pyexcel_io/sheet.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def write_row(self, array):
137137
"""
138138
write a row into the file
139139
"""
140-
raise NotImplementedError("Please implement write_row")
140+
raise NotImplementedError("Please implement write_row()")
141141

142142
def write_array(self, table):
143143
"""

tests/test_base.py

+18-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
11
from pyexcel_io.sheet import (
2-
SheetReader,
3-
SheetWriter, NamedContent
2+
SheetReader, SheetWriter, NamedContent
43
)
4+
from pyexcel_io.book import BookWriter
55
from pyexcel_io.utils import is_empty_array
66
from nose.tools import raises
77

88

9+
@raises(NotImplementedError)
10+
def test_book_writer():
11+
book = BookWriter()
12+
book.create_sheet("test")
13+
14+
915
def test_is_empty_array():
1016
a = ["", "", "", ""]
1117
assert is_empty_array(a) is True
@@ -47,6 +53,16 @@ def test_abstractness(self):
4753
reader = SheetReader("test")
4854
reader.cell_value(1, 2)
4955

56+
@raises(NotImplementedError)
57+
def test_number_of_columns(self):
58+
reader = SheetReader("test")
59+
reader.number_of_columns()
60+
61+
@raises(NotImplementedError)
62+
def test_number_of_rows(self):
63+
reader = SheetReader("test")
64+
reader.number_of_rows()
65+
5066
def test_to_array(self):
5167
name = "test"
5268

0 commit comments

Comments
 (0)