verify odfpy does close file handle, pyexcel/pyexcel-xlsx#14

Author: chfw

tests/test_bug_fixes.py

@@ -1,12 +1,14 @@
 #!/usr/bin/python
 # -*- encoding: utf-8 -*-
 import os
+import psutil
+import pyexcel as pe
 from pyexcel_ods import get_data, save_data
 from nose.tools import raises, eq_
 
 
 def test_bug_fix_for_issue_1():
-    data = get_data(os.path.join("tests", "fixtures", "repeated.ods"))
+    data = get_data(get_fixtures("repeated.ods"))
     eq_(data["Sheet1"], [['repeated', 'repeated', 'repeated', 'repeated']])
 
 
@@ -81,20 +83,53 @@ def test_issue_13():
 def test_issue_14():
     # pyexcel issue 61
     test_file = "issue_61.ods"
-    data = get_data(os.path.join("tests", "fixtures", test_file),
+    data = get_data(get_fixtures(test_file),
                     skip_empty_rows=True)
     eq_(data['S-LMC'], [[u'aaa'], [0]])
 
 
 def test_issue_6():
     test_file = "12_day_as_time.ods"
-    data = get_data(os.path.join("tests", "fixtures", test_file),
+    data = get_data(get_fixtures(test_file),
                     skip_empty_rows=True)
     eq_(data['Sheet1'][0][0].days, 12)
 
 
 def test_issue_19():
     test_file = "pyexcel_81_ods_19.ods"
-    data = get_data(os.path.join("tests", "fixtures", test_file),
+    data = get_data(get_fixtures(test_file),
                     skip_empty_rows=True)
     eq_(data['product.template'][1][1], 'PRODUCT NAME PMP')
+
+
+def test_issue_83_ods_file_handle():
+    # this proves that odfpy
+    # does not leave a file handle open at all
+    proc = psutil.Process()
+    test_file = get_fixtures("issue_61.ods")
+    open_files_l1 = proc.open_files()
+
+    # start with a csv file
+    data = pe.iget_array(file_name=test_file)
+    open_files_l2 = proc.open_files()
+    delta = len(open_files_l2) - len(open_files_l1)
+    # cannot catch open file handle
+    assert delta == 0
+
+    # now the file handle get opened when we run through
+    # the generator
+    list(data)
+    open_files_l3 = proc.open_files()
+    delta = len(open_files_l3) - len(open_files_l1)
+    # cannot catch open file handle
+    assert delta == 0
+
+    # free the fish
+    pe.free_resource()
+    open_files_l4 = proc.open_files()
+    # this confirms that no more open file handle
+    eq_(open_files_l1, open_files_l4)
+
+
+def get_fixtures(filename):
+    return os.path.join("tests", "fixtures", filename)