Skip to content

Commit 9c75d17

Browse files
committed
Attempt at fixing TypeError with newer versions of openpyxl (#52), thanks to @konstantin-lebejko
1 parent 3b3639d commit 9c75d17

File tree

7 files changed

+11
-10
lines changed

7 files changed

+11
-10
lines changed

Diff for: .gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ ipython_config.py
9090
# pyenv
9191
# For a library or package, you might want to ignore these files since the code is
9292
# intended to run in multiple environments; otherwise, check them in:
93-
# .python-version
93+
.python-version
9494

9595
# pipenv
9696
# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.

Diff for: CONTRIBUTORS.rst

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11

22

3-
3 contributors
3+
4 contributors
44
================================================================================
55

66
In alphabetical order:
77

88
* `Benoit Pierre <https://github.com/benoit-pierre>`_
9+
* `Craig Anderson <https://github.com/craiga>`_
910
* `John Vandenberg <https://github.com/jayvdb>`_
1011
* `Stephen J. Fuhry <https://github.com/fuhrysteve>`_

Diff for: pyexcel_xlsx/xlsxr.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def __init__(self, sheet, **keywords):
6969
self.max_column = 0
7070
self.__sheet_max_row = sheet.max_row
7171
self.__sheet_max_column = sheet.max_column
72-
for ranges in sheet.merged_cells.ranges[:]:
72+
for ranges in list(sheet.merged_cells.ranges)[:]:
7373
merged_cells = MergedCell(ranges)
7474
merged_cells.register_cells(self.__merged_cells)
7575
if self.max_row < merged_cells.bottom_row():

Diff for: tests/base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def test_reading_through_sheets(self):
8383
expected = [[4, 4, 4, 4], [5, 5, 5, 5], [6, 6, 6, 6]]
8484
assert data == expected
8585
data = list(b["Sheet3"].rows())
86-
expected = [[u"X", u"Y", u"Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]]
86+
expected = [["X", "Y", "Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]]
8787
assert data == expected
8888
sheet3 = b["Sheet3"]
8989
sheet3.name_columns_by_row(0)

Diff for: tests/test_multiple_sheets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,6 @@ def _produce_ordered_dict():
247247
data_dict.update({"Sheet1": [[1, 1, 1, 1], [2, 2, 2, 2], [3, 3, 3, 3]]})
248248
data_dict.update({"Sheet2": [[4, 4, 4, 4], [5, 5, 5, 5], [6, 6, 6, 6]]})
249249
data_dict.update(
250-
{"Sheet3": [[u"X", u"Y", u"Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]]}
250+
{"Sheet3": [["X", "Y", "Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]]}
251251
)
252252
return data_dict

Diff for: tests/test_reader.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import os
2-
from datetime import datetime, time
2+
from datetime import time, datetime
33

4-
from nose.tools import eq_
4+
from pyexcel_xlsx import get_data
55
from pyexcel_io._compact import OrderedDict
66

7-
from pyexcel_xlsx import get_data
7+
from nose.tools import eq_
88

99

1010
def test_reading():
1111
data = get_data(
1212
os.path.join("tests", "fixtures", "date_field.xlsx"),
1313
library="pyexcel-xlsx",
14-
skip_hidden_row_and_column=False
14+
skip_hidden_row_and_column=False,
1515
)
1616
expected = OrderedDict()
1717
expected.update(

Diff for: tests/test_writer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def test_write_book(self):
1010
self.content = {
1111
"Sheet1": [[1, 1, 1, 1], [2, 2, 2, 2], [3, 3, 3, 3]],
1212
"Sheet2": [[4, 4, 4, 4], [5, 5, 5, 5], [6, 6, 6, 6]],
13-
"Sheet3": [[u"X", u"Y", u"Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]],
13+
"Sheet3": [["X", "Y", "Z"], [1, 4, 7], [2, 5, 8], [3, 6, 9]],
1414
}
1515
self.testfile = "writer.xlsx"
1616
writer = Writer(self.testfile, "xlsx")

0 commit comments

Comments
 (0)