Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splited datas by 'RandomLinkSplit' have duplicated information. #6571

Closed
Cafelatte1 opened this issue Feb 2, 2023 · 7 comments · May be fixed by #10134
Closed

Splited datas by 'RandomLinkSplit' have duplicated information. #6571

Cafelatte1 opened this issue Feb 2, 2023 · 7 comments · May be fixed by #10134
Labels
refactor

Comments

@Cafelatte1
Copy link

🛠 Proposed Refactor

I found a something inefficient point in 'RandomLinkSplit'.
I think node feature (data.x) and edge information (data.edge_index) are not neccesary for all splited data class.
Just one data class only have to get the node feature and edge information.

image

Suggest a potential alternative/fix

How about change the output of function to yield only 'label' and 'splited edge index' like below?
Input on this function already have node feature and entire edge information.

image
@rusty1s
Copy link
Member

rusty1s commented Feb 2, 2023

I am happy to include this via an additional flag, such as keep_attrs=True/False. WDYT?

@Cafelatte1
Copy link
Author

Cafelatte1 commented Feb 2, 2023 •
edited
Loading

I am happy to include this via an additional flag, such as keep_attrs=True/False. WDYT?

'keep_attrs' seems not to be in 'RandomLinkSplit''s arguments.
I am using the 1.12.1+cpu version on windows.

@rusty1s
Copy link
Member

rusty1s commented Feb 2, 2023

Yes, I mean we would need to work on including this :)

@Cafelatte1
Copy link
Author

Yes, I mean we would need to work on including this :)

Ah ! I misunderstood :)
Yes it is a good simple way which includes an argument like that !

@rusty1s
Copy link
Member

rusty1s commented Feb 3, 2023

Do you have interest in contributing this? It isn't super high prio for me, so I would appreciate some help.

@Cafelatte1
Copy link
Author

Do you have interest in contributing this? It isn't super high prio for me, so I would appreciate some help.

Yes ! I am interested in contributing for this. Can you guide me about the process which improve this?

@rusty1s
Copy link
Member

rusty1s commented Feb 4, 2023

Did you take a look at CONTRIBUTING.md? Happy to answer any remaining questions.

@XinweiHe XinweiHe mentioned this issue Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
2 participants
@rusty1s @Cafelatte1