Remove all references to _infer

Author: DanielNoord

astroid/inference.py

@@ -86,15 +86,6 @@ def infer_end(
     yield self
 
 
-# We add ignores to all assignments to methods
-# See https://github.com/python/mypy/issues/2427
-nodes.Module._infer = infer_end
-nodes.ClassDef._infer = infer_end
-nodes.Lambda._infer = infer_end  # type: ignore[assignment]
-nodes.Const._infer = infer_end  # type: ignore[assignment]
-nodes.Slice._infer = infer_end  # type: ignore[assignment]
-
-
 def _infer_sequence_helper(
     node: _BaseContainerT, context: InferenceContext | None = None
 ) -> list[SuccessfulInferenceResult]:
@@ -140,11 +131,6 @@ def infer_sequence(
         yield self
 
 
-nodes.List._infer = infer_sequence  # type: ignore[assignment]
-nodes.Tuple._infer = infer_sequence  # type: ignore[assignment]
-nodes.Set._infer = infer_sequence  # type: ignore[assignment]
-
-
 def infer_map(
     self: nodes.Dict, context: InferenceContext | None = None
 ) -> Iterator[nodes.Dict]:
@@ -207,9 +193,6 @@ def _infer_map(
     return values
 
 
-nodes.Dict._infer = infer_map  # type: ignore[assignment]
-
-
 def _higher_function_scope(node: nodes.NodeNG) -> nodes.FunctionDef | None:
     """Search for the first function which encloses the given
     scope. This can be used for looking up in that function's
@@ -255,6 +238,8 @@ def infer_name(
     return bases._infer_stmts(stmts, context, frame)
 
 
+# The order of the decorators here is important
+# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def _infer_name(
@@ -265,12 +250,6 @@ def _infer_name(
     return infer_name(self, context, **kwargs)
 
 
-# pylint: disable=no-value-for-parameter
-# The order of the decorators here is important
-# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
-nodes.Name._infer = decorators.raise_if_nothing_inferred(
-    decorators.path_wrapper(infer_name)
-)
 nodes.AssignName.infer_lhs = infer_name  # won't work with a path wrapper
 
 
@@ -300,9 +279,6 @@ def infer_call(
     return InferenceErrorInfo(node=self, context=context)
 
 
-nodes.Call._infer = infer_call  # type: ignore[assignment]
-
-
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def infer_import(
@@ -326,9 +302,6 @@ def infer_import(
         raise InferenceError(node=self, context=context) from exc
 
 
-nodes.Import._infer = infer_import
-
-
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def infer_import_from(
@@ -364,9 +337,6 @@ def infer_import_from(
         ) from error
 
 
-nodes.ImportFrom._infer = infer_import_from  # type: ignore[assignment]
-
-
 def infer_attribute(
     self: nodes.Attribute | nodes.AssignAttr,
     context: InferenceContext | None = None,
@@ -399,6 +369,8 @@ def infer_attribute(
     return InferenceErrorInfo(node=self, context=context)
 
 
+# The order of the decorators here is important
+# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def _infer_attribute(
@@ -409,11 +381,6 @@ def _infer_attribute(
     return infer_attribute(self, context, **kwargs)
 
 
-# The order of the decorators here is important
-# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
-nodes.Attribute._infer = decorators.raise_if_nothing_inferred(
-    decorators.path_wrapper(infer_attribute)
-)
 # won't work with a path wrapper
 nodes.AssignAttr.infer_lhs = decorators.raise_if_nothing_inferred(infer_attribute)
 
@@ -433,9 +400,6 @@ def infer_global(
         ) from error
 
 
-nodes.Global._infer = infer_global  # type: ignore[assignment]
-
-
 _SUBSCRIPT_SENTINEL = object()
 
 
@@ -498,6 +462,8 @@ def infer_subscript(
     return None
 
 
+# The order of the decorators here is important
+# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def _infer_subscript(
@@ -506,11 +472,6 @@ def _infer_subscript(
     return infer_subscript(self, context=context, **kwargs)
 
 
-# The order of the decorators here is important
-# See https://github.com/pylint-dev/astroid/commit/0a8a75db30da060a24922e05048bc270230f5
-nodes.Subscript._infer = decorators.raise_if_nothing_inferred(  # type: ignore[assignment]
-    decorators.path_wrapper(infer_subscript)
-)
 nodes.Subscript.infer_lhs = decorators.raise_if_nothing_inferred(infer_subscript)
 
 
@@ -569,9 +530,6 @@ def _infer_boolop(
     return InferenceErrorInfo(node=self, context=context)
 
 
-nodes.BoolOp._infer = _infer_boolop
-
-
 # UnaryOp, BinOp and AugAssign inferences
 
 
@@ -668,7 +626,6 @@ def infer_unaryop(
 
 
 nodes.UnaryOp._infer_unaryop = _infer_unaryop
-nodes.UnaryOp._infer = infer_unaryop
 
 
 def _is_not_implemented(const) -> bool:
@@ -1020,7 +977,6 @@ def infer_binop(
 
 
 nodes.BinOp._infer_binop = _infer_binop
-nodes.BinOp._infer = infer_binop
 
 COMPARE_OPS: dict[str, Callable[[Any, Any], bool]] = {
     "==": operator.eq,
@@ -1118,9 +1074,6 @@ def _infer_compare(
         yield nodes.Const(retval)
 
 
-nodes.Compare._infer = _infer_compare  # type: ignore[assignment]
-
-
 def _infer_augassign(
     self: nodes.AugAssign, context: InferenceContext | None = None
 ) -> Generator[InferenceResult | util.BadBinaryOperationMessage, None, None]:
@@ -1160,7 +1113,6 @@ def infer_augassign(
 
 
 nodes.AugAssign._infer_augassign = _infer_augassign
-nodes.AugAssign._infer = infer_augassign
 
 # End of binary operation inference.
 
@@ -1174,9 +1126,6 @@ def infer_arguments(
     return protocols._arguments_infer_argname(self, context.lookupname, context)
 
 
-nodes.Arguments._infer = infer_arguments  # type: ignore[assignment]
-
-
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def infer_assign(
@@ -1194,10 +1143,6 @@ def infer_assign(
     return bases._infer_stmts(stmts, context)
 
 
-nodes.AssignName._infer = infer_assign
-nodes.AssignAttr._infer = infer_assign
-
-
 @decorators.raise_if_nothing_inferred
 @decorators.path_wrapper
 def infer_empty_node(
@@ -1214,9 +1159,6 @@ def infer_empty_node(
             yield util.Uninferable
 
 
-nodes.EmptyNode._infer = infer_empty_node  # type: ignore[assignment]
-
-
 def _populate_context_lookup(call: nodes.Call, context: InferenceContext | None):
     # Allows context to be saved for later
     # for inference inside a function
@@ -1269,9 +1211,6 @@ def infer_ifexp(
         yield from self.orelse.infer(context=rhs_context)
 
 
-nodes.IfExp._infer = infer_ifexp  # type: ignore[assignment]
-
-
 def infer_functiondef(
     self: _FunctionDefT, context: InferenceContext | None = None, **kwargs: Any
 ) -> Generator[Property | _FunctionDefT, None, InferenceErrorInfo]:
@@ -1306,9 +1245,6 @@ def infer_functiondef(
     return InferenceErrorInfo(node=self, context=context)
 
 
-nodes.FunctionDef._infer = infer_functiondef
-
-
 # pylint: disable-next=too-many-return-statements
 def _infer_node(
     node: nodes.NodeNG, context: InferenceContext | None = None, **kwargs: Any

astroid/nodes/node_classes.py

@@ -3932,10 +3932,6 @@ def __init__(
     def qname(self) -> Literal["Unknown"]:
         return "Unknown"
 
-    def _infer(self, context: InferenceContext | None = None, **kwargs):
-        """Inference on an Unknown node immediately terminates."""
-        yield util.Uninferable
-
 
 class EvaluatedObject(NodeNG):
     """Contains an object that has already been inferred
@@ -3963,11 +3959,6 @@ def __init__(self, original: NodeNG, value: NodeNG | util.UninferableBase) -> No
             end_col_offset=self.original.end_col_offset,
         )
 
-    def _infer(
-        self, context: InferenceContext | None = None, **kwargs: Any
-    ) -> Generator[NodeNG | util.UninferableBase, None, None]:
-        yield self.value
-
 
 # Pattern matching #######################################################
 

astroid/nodes/node_ng.py

@@ -26,14 +26,13 @@
 from astroid.context import InferenceContext
 from astroid.exceptions import (
     AstroidError,
-    InferenceError,
     ParentMissingError,
     StatementMissing,
 )
 from astroid.nodes.as_string import AsStringVisitor
 from astroid.nodes.const import OP_PRECEDENCE
 from astroid.nodes.utils import Position
-from astroid.typing import InferenceErrorInfo, InferenceResult, InferFn
+from astroid.typing import InferenceResult, InferFn
 
 if TYPE_CHECKING:
     from astroid import nodes
@@ -537,15 +536,6 @@ def _infer_name(self, frame, name):
         # overridden for ImportFrom, Import, Global, TryExcept, TryStar and Arguments
         pass
 
-    def _infer(
-        self, context: InferenceContext | None = None, **kwargs: Any
-    ) -> Generator[InferenceResult, None, InferenceErrorInfo | None]:
-        """We don't know how to resolve a statement by default."""
-        # this method is overridden by most concrete classes
-        raise InferenceError(
-            "No inference function for {node!r}.", node=self, context=context
-        )
-
     def inferred(self):
         """Get a list of the inferred values.
 

astroid/objects.py

@@ -13,9 +13,9 @@
 
 from __future__ import annotations
 
-from collections.abc import Generator, Iterator
+from collections.abc import Iterator
 from functools import cached_property
-from typing import Any, Literal, NoReturn, TypeVar
+from typing import Literal, NoReturn, TypeVar
 
 from astroid import bases, decorators, util
 from astroid.context import InferenceContext
@@ -39,9 +39,6 @@ class FrozenSet(node_classes.BaseContainer):
     def pytype(self) -> Literal["builtins.frozenset"]:
         return "builtins.frozenset"
 
-    def _infer(self, context: InferenceContext | None = None, **kwargs: Any):
-        yield self
-
     @cached_property
     def _proxied(self):  # pylint: disable=method-hidden
         ast_builtins = AstroidManager().builtins_module
@@ -84,9 +81,6 @@ def __init__(
             end_col_offset=scope.end_col_offset,
         )
 
-    def _infer(self, context: InferenceContext | None = None, **kwargs: Any):
-        yield self
-
     def super_mro(self):
         """Get the MRO which will be used to lookup attributes in this super."""
         if not isinstance(self.mro_pointer, scoped_nodes.ClassDef):
@@ -366,8 +360,3 @@ def infer_call_result(
         context: InferenceContext | None = None,
     ) -> NoReturn:
         raise InferenceError("Properties are not callable")
-
-    def _infer(
-        self: _T, context: InferenceContext | None = None, **kwargs: Any
-    ) -> Generator[_T, None, None]:
-        yield self

tests/test_inference.py

@@ -40,6 +40,7 @@
     NotFoundError,
 )
 from astroid.inference import infer_end as inference_infer_end
+from astroid.inference import infer_object
 from astroid.objects import ExceptionInstance
 
 from . import resources
@@ -7022,7 +7023,7 @@ def patch(cls):
 def test_function_def_cached_generator() -> None:
     """Regression test for https://github.com/pylint-dev/astroid/issues/817."""
     funcdef: nodes.FunctionDef = extract_node("def func(): pass")
-    next(funcdef._infer())
+    next(infer_object(funcdef))
 
 
 class TestOldStyleStringFormatting: