Skip to content

Commit bb41fd7

Browse files
committed
Revert "List Django as a dependency. Fix #96"
This reverts commit 9b520e9. Apparently this is causing more problems than it solves, see: #132
1 parent 8221084 commit bb41fd7

File tree

2 files changed

+9
-24
lines changed

2 files changed

+9
-24
lines changed

Diff for: README.md

+9-23
Original file line numberDiff line numberDiff line change
@@ -10,33 +10,19 @@ pylint-django
1010

1111
`pylint-django` is a [Pylint](http://pylint.org) plugin for improving code analysis for when analysing code using Django. It is also used by the [Prospector](https://github.com/landscapeio/prospector) tool.
1212

13-
# Installation
13+
## Usage
1414

15-
```
16-
pip install pylint-django
17-
```
18-
19-
**WARNING:** `pylint-django` requires `Django` to be installed. Our `setup.py` file doesn't
20-
specify which particular version of Django is going to be installed because we have no idea
21-
what version is used inside your project. The latest version of Django will be installed if
22-
it has not been installed beforehand! DO NOT report issues about mismatching Django versions
23-
if that happens. Instead get your testing environment sorted out and make sure that you have
24-
the appropriate version of Django installed!
25-
26-
# Usage
27-
28-
## Pylint
15+
#### Pylint
2916

30-
Ensure `pylint-django` is installed and on your path and then execute:
17+
Ensure `pylint-django` is installed and on your path (`pip install pylint-django`), and then run pylint:
3118

3219
```
3320
pylint --load-plugins pylint_django [..other options..]
3421
```
3522

36-
## Prospector
23+
#### Prospector
3724

38-
If you have `prospector` installed, then `pylint-django` will already be installed as a dependency,
39-
and will be activated automatically if Django is detected.
25+
If you have `prospector` installed, then `pylint-django` will already be installed as a dependency, and will be activated automatically if Django is detected.
4026

4127
```
4228
prospector [..other options..]
@@ -56,14 +42,14 @@ Please feel free to add your name to the `CONTRIBUTORS.md` file if you want to b
5642
credited when pull requests get merged. You can also add to the `CHANGELOG.md` file
5743
if you wish, although I'll also do that when merging if not.
5844

59-
# Tests
45+
## Tests
6046

6147
The structure of the test package follows that from pylint itself.
6248

6349
It is fairly simple: create a module starting with `func_` followed by
6450
a test name, and insert into it some code. The tests will run pylint
65-
against these modules. If the idea is that no messages now occur, then
66-
that is fine, just check to see if it works by running `scripts/test.sh`.
51+
against these modules. If the idea is that no messages now occur, then
52+
that is fine, just check to see if it works by running `scripts/test.sh`.
6753

6854
Ideally, add some pylint error suppression messages to the file to prevent
6955
spurious warnings, since these are all tiny little modules not designed to
@@ -78,4 +64,4 @@ These are useful to quickly add "expected messages".
7864

7965
# License
8066

81-
`pylint-django` is available under the GPLv2 license.
67+
`pylint-django` is available under the GPLv2 license.

Diff for: setup.py

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
install_requires=[
1919
'pylint-plugin-utils>=0.2.1',
2020
'pylint>=1.8.2',
21-
'Django',
2221
],
2322
license='GPLv2',
2423
classifiers=[

0 commit comments

Comments
 (0)