Skip to content

Commit 0c37d4c

Browse files
cdce8pcdce8p
authored
Update ranges for error messages (#6606)
* using-constant-test * missing-parentheses-for-call-in-test
1 parent 30042ec commit 0c37d4c

File tree

6 files changed

+51
-45
lines changed

6 files changed

+51
-45
lines changed

‎ChangeLog

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,9 @@ Release date: TBA
318318

319319
Ref #6536
320320

321+
* Update ranges for ``using-constant-test`` and ``missing-parentheses-for-call-in-test``
322+
error messages.
323+
321324
..
322325
Insert your changelog randomly, it will reduce merge conflicts
323326
(Ie. not necessarily at the end)

‎doc/whatsnew/2.14.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,9 @@ Other Changes
263263

264264
Refs #6595
265265

266+
* Update ranges for ``using-constant-test`` and ``missing-parentheses-for-call-in-test``
267+
error messages.
268+
266269
Deprecations
267270
============
268271

‎pylint/checkers/base/basic_checker.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ def _check_using_constant_test(self, node, test):
312312
inferred = utils.safe_infer(test)
313313

314314
if emit:
315-
self.add_message("using-constant-test", node=node)
315+
self.add_message("using-constant-test", node=test)
316316
elif isinstance(inferred, const_nodes):
317317
# If the constant node is a FunctionDef or Lambda then
318318
# it may be an illicit function call due to missing parentheses
@@ -329,12 +329,12 @@ def _check_using_constant_test(self, node, test):
329329
for inf_call in call_inferred:
330330
if inf_call != astroid.Uninferable:
331331
self.add_message(
332-
"missing-parentheses-for-call-in-test", node=node
332+
"missing-parentheses-for-call-in-test", node=test
333333
)
334334
break
335335
except astroid.InferenceError:
336336
pass
337-
self.add_message("using-constant-test", node=node)
337+
self.add_message("using-constant-test", node=test)
338338

339339
def visit_module(self, _: nodes.Module) -> None:
340340
"""Check module name, docstring and required arguments."""

‎tests/functional/ext/docparams/raise/missing_raises_doc_Google.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ missing-raises-doc:148:4:148:18:Foo.foo_method:"""AttributeError"" not documente
1111
unreachable:158:8:158:17:Foo.foo_method:Unreachable code:UNDEFINED
1212
unreachable:180:8:180:17:Foo.foo_method:Unreachable code:UNDEFINED
1313
missing-raises-doc:183:4:183:18:Foo.foo_method:"""AttributeError"" not documented as being raised":UNDEFINED
14-
using-constant-test:190:8:191:34:Foo.foo_method:Using a conditional statement with a constant value:UNDEFINED
14+
using-constant-test:190:11:190:15:Foo.foo_method:Using a conditional statement with a constant value:UNDEFINED

‎tests/functional/m/missing/missing_parentheses_for_call_in_test.txt

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
missing-parentheses-for-call-in-test:29:0:30:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
2-
missing-parentheses-for-call-in-test:35:0:36:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
3-
missing-parentheses-for-call-in-test:43:0:44:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
4-
missing-parentheses-for-call-in-test:51:0:52:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
5-
missing-parentheses-for-call-in-test:56:0:57:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
6-
missing-parentheses-for-call-in-test:64:0:65:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
7-
missing-parentheses-for-call-in-test:70:11:70:38::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
8-
missing-parentheses-for-call-in-test:72:17:72:42::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
9-
missing-parentheses-for-call-in-test:73:18:73:46::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
10-
missing-parentheses-for-call-in-test:75:0:None:None::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
11-
missing-parentheses-for-call-in-test:76:0:None:None::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
12-
missing-parentheses-for-call-in-test:79:0:None:None::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
13-
missing-parentheses-for-call-in-test:80:0:None:None::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
14-
missing-parentheses-for-call-in-test:85:0:86:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
15-
missing-parentheses-for-call-in-test:91:0:92:8::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
1+
missing-parentheses-for-call-in-test:29:3:29:16::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
2+
missing-parentheses-for-call-in-test:35:3:35:19::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
3+
missing-parentheses-for-call-in-test:43:3:43:23::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
4+
missing-parentheses-for-call-in-test:51:5:51:25::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
5+
missing-parentheses-for-call-in-test:56:3:56:14::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
6+
missing-parentheses-for-call-in-test:64:3:64:17::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
7+
missing-parentheses-for-call-in-test:70:17:70:30::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
8+
missing-parentheses-for-call-in-test:72:23:72:34::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
9+
missing-parentheses-for-call-in-test:73:24:73:38::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
10+
missing-parentheses-for-call-in-test:75:26:75:39::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
11+
missing-parentheses-for-call-in-test:76:26:76:37::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
12+
missing-parentheses-for-call-in-test:79:26:79:40::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
13+
missing-parentheses-for-call-in-test:80:26:80:42::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
14+
missing-parentheses-for-call-in-test:85:3:85:26::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED
15+
missing-parentheses-for-call-in-test:91:3:91:20::Using a conditional statement with potentially wrong function or method call due to missing parentheses:UNDEFINED

‎tests/functional/u/using_constant_test.txt

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
1-
using-constant-test:22:0:23:8::Using a conditional statement with a constant value:UNDEFINED
2-
using-constant-test:26:0:27:8::Using a conditional statement with a constant value:UNDEFINED
3-
using-constant-test:29:0:30:8::Using a conditional statement with a constant value:UNDEFINED
4-
using-constant-test:32:0:33:8::Using a conditional statement with a constant value:UNDEFINED
5-
using-constant-test:35:0:36:8::Using a conditional statement with a constant value:UNDEFINED
6-
using-constant-test:38:0:39:8::Using a conditional statement with a constant value:UNDEFINED
7-
using-constant-test:41:0:42:8::Using a conditional statement with a constant value:UNDEFINED
8-
using-constant-test:44:0:45:8::Using a conditional statement with a constant value:UNDEFINED
9-
using-constant-test:47:0:48:8::Using a conditional statement with a constant value:UNDEFINED
10-
using-constant-test:50:0:51:8::Using a conditional statement with a constant value:UNDEFINED
11-
using-constant-test:53:0:54:8::Using a conditional statement with a constant value:UNDEFINED
12-
using-constant-test:56:0:57:8::Using a conditional statement with a constant value:UNDEFINED
13-
using-constant-test:59:0:60:8::Using a conditional statement with a constant value:UNDEFINED
14-
using-constant-test:62:0:63:8::Using a conditional statement with a constant value:UNDEFINED
15-
using-constant-test:65:0:66:8::Using a conditional statement with a constant value:UNDEFINED
16-
using-constant-test:68:0:69:8::Using a conditional statement with a constant value:UNDEFINED
17-
using-constant-test:73:0:74:8::Using a conditional statement with a constant value:UNDEFINED
18-
using-constant-test:76:3:76:16::Using a conditional statement with a constant value:UNDEFINED
19-
using-constant-test:80:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
20-
using-constant-test:81:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
21-
using-constant-test:82:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
22-
using-constant-test:83:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
23-
using-constant-test:84:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
24-
using-constant-test:85:0:None:None:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
25-
using-constant-test:89:0:90:8::Using a conditional statement with a constant value:UNDEFINED
26-
using-constant-test:93:0:94:8::Using a conditional statement with a constant value:UNDEFINED
1+
using-constant-test:22:3:22:14::Using a conditional statement with a constant value:UNDEFINED
2+
using-constant-test:26:3:26:31::Using a conditional statement with a constant value:UNDEFINED
3+
using-constant-test:29:3:29:15:<lambda>:Using a conditional statement with a constant value:UNDEFINED
4+
using-constant-test:32:3:32:11::Using a conditional statement with a constant value:UNDEFINED
5+
using-constant-test:35:3:35:8::Using a conditional statement with a constant value:UNDEFINED
6+
using-constant-test:38:3:38:4::Using a conditional statement with a constant value:UNDEFINED
7+
using-constant-test:41:3:41:7::Using a conditional statement with a constant value:UNDEFINED
8+
using-constant-test:44:3:44:5::Using a conditional statement with a constant value:UNDEFINED
9+
using-constant-test:47:3:47:6::Using a conditional statement with a constant value:UNDEFINED
10+
using-constant-test:50:3:50:6::Using a conditional statement with a constant value:UNDEFINED
11+
using-constant-test:53:3:53:5::Using a conditional statement with a constant value:UNDEFINED
12+
using-constant-test:56:3:56:12::Using a conditional statement with a constant value:UNDEFINED
13+
using-constant-test:59:3:59:12::Using a conditional statement with a constant value:UNDEFINED
14+
using-constant-test:62:3:62:5::Using a conditional statement with a constant value:UNDEFINED
15+
using-constant-test:65:3:65:12::Using a conditional statement with a constant value:UNDEFINED
16+
using-constant-test:68:3:68:5::Using a conditional statement with a constant value:UNDEFINED
17+
using-constant-test:73:3:73:12::Using a conditional statement with a constant value:UNDEFINED
18+
using-constant-test:76:8:76:9::Using a conditional statement with a constant value:UNDEFINED
19+
using-constant-test:80:36:80:39:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
20+
using-constant-test:81:36:81:37:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
21+
using-constant-test:82:36:82:39:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
22+
using-constant-test:83:36:83:37:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
23+
using-constant-test:84:36:84:39:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
24+
using-constant-test:85:39:85:42:test_comprehensions:Using a conditional statement with a constant value:UNDEFINED
25+
using-constant-test:89:3:89:15::Using a conditional statement with a constant value:UNDEFINED
26+
using-constant-test:93:3:93:18::Using a conditional statement with a constant value:UNDEFINED
2727
comparison-of-constants:117:3:117:8::"Comparison between constants: '2 < 3' has a constant value":HIGH

0 commit comments

Comments
 (0)