Fix existing code

Author: cdce8p

pylint/checkers/classes.py

@@ -981,7 +981,7 @@ def _check_unused_private_attributes(self, node: astroid.ClassDef) -> None:
                     (
                         # If assigned to cls.attrib, can be accessed by cls/self
                         assign_attr.expr.name == "cls"
-                        and attribute.expr.name in ["cls", "self"]
+                        and attribute.expr.name in ("cls", "self")
                     )
                     # If assigned to self.attrib, can only be accessed by self
                     # Or if __new__ was used, the returned object names are acceptable

pylint/checkers/python3.py

@@ -156,7 +156,7 @@ def _in_iterating_context(node):
     elif (
         isinstance(parent, astroid.Compare)
         and len(parent.ops) == 1
-        and parent.ops[0][0] in ["in", "not in"]
+        and parent.ops[0][0] in ("in", "not in")
     ):
         return True
     # Also if it's an `yield from`, that's fair

pylint/checkers/refactoring/refactoring_checker.py

@@ -943,7 +943,7 @@ def _check_consider_using_generator(self, node):
                 # remove square brackets '[]'
                 inside_comp = node.args[0].as_string()[1:-1]
                 call_name = node.func.name
-                if call_name in ["any", "all"]:
+                if call_name in ("any", "all"):
                     self.add_message(
                         "use-a-generator",
                         node=node,

pylint/checkers/stdlib.py

@@ -558,7 +558,7 @@ def _check_redundant_assert(self, node, infer):
             isinstance(infer, astroid.BoundMethod)
             and node.args
             and isinstance(node.args[0], astroid.Const)
-            and infer.name in ["assertTrue", "assertFalse"]
+            and infer.name in ("assertTrue", "assertFalse")
         ):
             self.add_message(
                 "redundant-unittest-assert",

pylint/checkers/typecheck.py

@@ -518,7 +518,7 @@ def _emit_no_member(node, owner, owner_name, ignored_mixins=True, ignored_none=T
         and isinstance(owner.parent, astroid.ClassDef)
         and owner.parent.name == "EnumMeta"
         and owner_name == "__members__"
-        and node.attrname in ["items", "values", "keys"]
+        and node.attrname in ("items", "values", "keys")
     ):
         # Avoid false positive on Enum.__members__.{items(), values, keys}
         # See https://github.com/PyCQA/pylint/issues/4123
@@ -1781,7 +1781,7 @@ def visit_compare(self, node):
             return
 
         op, right = node.ops[0]
-        if op in ["in", "not in"]:
+        if op in ("in", "not in"):
             self._check_membership_test(right)
 
     @check_messages(

pylint/lint/pylinter.py

@@ -717,7 +717,7 @@ def any_fail_on_issues(self):
     def disable_noerror_messages(self):
         for msgcat, msgids in self.msgs_store._msgs_by_category.items():
             # enable only messages with 'error' severity and above ('fatal')
-            if msgcat in ["E", "F"]:
+            if msgcat in ("E", "F"):
                 for msgid in msgids:
                     self.enable(msgid)
             else:

script/bump_changelog.py

@@ -136,7 +136,7 @@ def do_checks(content, next_version, version, version_type):
     wn_next_version = get_whats_new(next_version)
     wn_this_version = get_whats_new(version)
     # There is only one field where the release date is TBA
-    if version_type in [VersionType.MAJOR, VersionType.MINOR]:
+    if version_type in (VersionType.MAJOR, VersionType.MINOR):
         assert (
             content.count(RELEASE_DATE_TEXT) <= 1
         ), f"There should be only one release date 'TBA' ({version}) {err}"