Improve error message arguments formatting [redefined-slots] (#5754)

cdce8p · web-flow · commit 1c884efd0ddc · 2022-01-31T22:53:15.000+01:00
diff --git a/pylint/checkers/classes/class_checker.py b/pylint/checkers/classes/class_checker.py
@@ -1397,7 +1397,7 @@ def _check_redefined_slots(
         if redefined_slots:
             self.add_message(
                 "redefined-slots-in-subclass",
-                args=", ".join(name for name in slots_names if name in redefined_slots),
+                args=([name for name in slots_names if name in redefined_slots],),
                 node=slots_node,
             )
 
diff --git a/tests/functional/r/redefined_slots.txt b/tests/functional/r/redefined_slots.txt
@@ -1,2 +1,2 @@
-redefined-slots-in-subclass:15:16:15:47:Subclass1:Redefined slots 'a, deque' in subclass:UNDEFINED
-redefined-slots-in-subclass:33:16:33:61:Subclass3:Redefined slots 'a, b, i, j, k' in subclass:UNDEFINED
+redefined-slots-in-subclass:15:16:15:47:Subclass1:Redefined slots ['a', 'deque'] in subclass:UNDEFINED
+redefined-slots-in-subclass:33:16:33:61:Subclass3:Redefined slots ['a', 'b', 'i', 'j', 'k'] in subclass:UNDEFINED

Original file line number	Diff line number	Diff line change
`@@ -1397,7 +1397,7 @@ def _check_redefined_slots(`
`1397`	`1397`	`if redefined_slots:`
`1398`	`1398`	`self.add_message(`
`1399`	`1399`	`"redefined-slots-in-subclass",`
`1400`		`- args=", ".join(name for name in slots_names if name in redefined_slots),`
	`1400`	`+ args=([name for name in slots_names if name in redefined_slots],),`
`1401`	`1401`	`node=slots_node,`
`1402`	`1402`	`)`
`1403`	`1403`