Add bad-option-value

Co-authored-by: Pierre Sassoulas <[email protected]>

Author: DanielNoord

ChangeLog

@@ -90,6 +90,12 @@ Release date: TBA
 
   Closes #5205
 
+* ``bad-option-value`` will be emitted whenever a configuration value or command line invocation
+  includes an unknown message.
+
+  Closes #4324
+
+
 * Added the ``generate-toml-config`` option.
 
   Ref #5462

doc/whatsnew/2.14.rst

@@ -104,6 +104,11 @@ Other Changes
 
   Ref #5462
 
+* ``bad-option-value`` will be emitted whenever a configuration value or command line invocation
+  includes an unknown message.
+
+  Closes #4324
+
 * Fix false negative for ``bad-string-format-type`` if the value to be formatted is passed in
   as a variable holding a constant.
 

pylint/config/callback_actions.py

@@ -382,9 +382,8 @@ def __call__(
             try:
                 self.linter.disable(msgid)
             except exceptions.UnknownMessageError:
-                # pylint: disable-next=fixme
-                # TODO: Optparse: Raise an informational warning here
-                pass
+                msg = f"{option_string}. Don't recognize message {msgid}."
+                self.linter.add_message("bad-option-value", args=msg, line=0)
 
 
 class _EnableAction(_AccessLinterObjectAction):
@@ -403,9 +402,8 @@ def __call__(
             try:
                 self.linter.enable(msgid)
             except exceptions.UnknownMessageError:
-                # pylint: disable-next=fixme
-                # TODO: Optparse: Raise an informational warning here
-                pass
+                msg = f"{option_string}. Don't recognize message {msgid}."
+                self.linter.add_message("bad-option-value", args=msg, line=0)
 
 
 class _OutputFormatAction(_AccessLinterObjectAction):

pylint/config/config_initialization.py

@@ -58,10 +58,18 @@ def _config_initialization(
     if reporter:
         linter.set_reporter(reporter)
 
+    # Set the current module to the command line
+    # to allow raising messages on it
+    linter.set_current_module("Command line")
+
     # Now we parse any options from the command line, so they can override
     # the configuration file
     parsed_args_list = linter._parse_command_line_configuration(args_list)
 
+    # Set the current module to configuration as we don't know where
+    # the --load-plugins key is coming from
+    linter.set_current_module("Command line or configuration file")
+
     # We have loaded configuration from config file and command line. Now, we can
     # load plugin specific configuration.
     linter.load_plugin_configuration()

pylint/lint/pylinter.py

@@ -168,7 +168,7 @@ def _load_reporter_by_class(reporter_class: str) -> type:
         "Used when an unknown inline option is encountered.",
     ),
     "E0012": (
-        "Bad option value %r",
+        "Bad option value for %s",
         "bad-option-value",
         "Used when a bad value for an inline option is encountered.",
     ),
@@ -937,8 +937,9 @@ def process_tokens(self, tokens):
                         try:
                             meth(msgid, "module", l_start)
                         except exceptions.UnknownMessageError:
+                            msg = f"{pragma_repr.action}. Don't recognize message {msgid}."
                             self.add_message(
-                                "bad-option-value", args=msgid, line=start[0]
+                                "bad-option-value", args=msg, line=start[0]
                             )
             except UnRecognizedOptionError as err:
                 self.add_message(

tests/config/functional/toml/issue_4746/loaded_plugin_does_not_exists.2.out

@@ -1,2 +1,2 @@
-************* Module {abspath}
-{relpath}:1:0: E0013: Plugin 'pylint_websockets' is impossible to load, is it installed ? ('No module named 'pylint_websockets'') (bad-plugin-value)
+************* Module Command line or configuration file
+Command line or configuration file:1:0: E0013: Plugin 'pylint_websockets' is impossible to load, is it installed ? ('No module named 'pylint_websockets'') (bad-plugin-value)

tests/config/functional/toml/unknown_msgid/enable_unknown_msgid.2.out

@@ -0,0 +1,3 @@
+************* Module {abspath}
+{relpath}:1:0: E0012: Bad option value for --disable. Don't recognize message logging-not-layzy. (bad-option-value)
+{relpath}:1:0: E0012: Bad option value for --enable. Don't recognize message C00000. (bad-option-value)

tests/config/test_config.py

@@ -7,9 +7,15 @@
 import os
 from pathlib import Path
 
-from pylint.lint.run import Run
+from pytest import CaptureFixture
+
+from pylint.lint import Run
 from pylint.testutils.configuration_test import run_using_a_configuration_file
 
+HERE = Path(__file__).parent.absolute()
+REGRTEST_DATA_DIR = HERE / ".." / "regrtest_data"
+EMPTY_MODULE = REGRTEST_DATA_DIR / "empty.py"
+
 
 def check_configuration_file_reader(
     runner: Run,
@@ -45,3 +51,10 @@ def test_can_read_toml_env_variable(tmp_path: Path, file_to_lint_path: str) -> N
     )
     mock_exit.assert_called_once_with(0)
     check_configuration_file_reader(runner)
+
+
+def test_unknown_message_id(capsys: CaptureFixture) -> None:
+    """Check that we correctly raise a message on an unknown id."""
+    Run([str(EMPTY_MODULE), "--disable=12345"], exit=False)
+    output = capsys.readouterr()
+    assert "Command line:1:0: E0012: Bad option value for --disable." in output.out

tests/functional/b/bad_option_value.txt

@@ -1 +1 @@
-bad-option-value:1:0:None:None::Bad option value 'W04044':UNDEFINED
+bad-option-value:1:0:None:None::Bad option value for enable. Don't recognize message W04044.:UNDEFINED

tests/functional/u/use/use_symbolic_message_instead.txt

@@ -1,4 +1,4 @@
-bad-option-value:1:0:None:None::Bad option value 'T1234':UNDEFINED
+bad-option-value:1:0:None:None::Bad option value for disable. Don't recognize message T1234.:UNDEFINED
 use-symbolic-message-instead:1:0:None:None::"'C0111' is cryptic: use '# pylint: disable=missing-docstring' instead":UNDEFINED
 use-symbolic-message-instead:1:0:None:None::"'R0903' is cryptic: use '# pylint: disable=too-few-public-methods' instead":UNDEFINED
 use-symbolic-message-instead:2:0:None:None::"'c0111' is cryptic: use '# pylint: enable=missing-docstring' instead":UNDEFINED