Move TestForAnyAll to functional tests (#5436)

* Move test_for_any_all to functional

* Convert additional for_any_all tests to functional

Author: areveny

tests/extensions/test_for_any_all.py

@@ -59,3 +59,88 @@ def words_contains_word(words):
         if word == "word":
             return True
     return False
+
+def complicated_condition_check(items):
+    """Case where we expect not any statement with a more complicated condition"""
+    for item in items: # [consider-using-any-or-all]
+        if item % 2 == 0 and (item % 3 == 0 or item > 15):
+            return False
+    return True
+
+def is_from_decorator1(node):
+    """Case where we expect a particularly long message to be emitted."""
+    for ancestor in node: # [consider-using-any-or-all]
+        if (
+            ancestor.name in ("Exception", "BaseException")
+            and ancestor.root().name == "Exception"
+        ):
+            return True
+    return False
+
+def is_from_decorator2(items):
+    """Case where we expect an all statement because of negation in the condition"""
+    for item in items: # [consider-using-any-or-all]
+        if not(item % 2 == 0 and (item % 3 == 0 or item > 15)):
+            return False
+    return True
+
+def is_from_decorator3(node):
+    """Case where we expect a not all statement because of negation in the condition"""
+    for ancestor in node: # [consider-using-any-or-all]
+        if not (
+            ancestor.name in ("Exception", "BaseException")
+            and ancestor.root().name == "Exception"
+        ):
+            return True
+    return False
+
+def no_suggestion_if_not_if():
+    """Do not emit if the for loop does not have the pattern we are looking for"""
+    for val in range(1):
+        var = val
+        return var
+
+def no_suggestion_if_not_bool(item):
+    """Do not emit if the if-statement does not return a bool"""
+    for parent in item.parents():
+        if isinstance(parent, str):
+            return "True"
+    return "False"
+
+def print_items(items):
+    """Do not emit if there is no If condition in the for loop."""
+    for item in items:
+        print(item)
+    return True
+
+def print_items2(items):
+    """Do not emit if anything besides a boolean is returned."""
+    for item in items:
+        return item
+    return True
+
+def print_items3(items):
+    """Do not emit if anything besides a boolean is returned."""
+    for _ in items:
+        return False
+    return items
+
+def print_items4(items):
+    """Do not emit if there is more logic which can cause side effects
+    or become less readable in a list comprehension.
+    """
+    for item in items:
+        if isinstance(item, str):
+            print(item)
+            return False
+    return True
+
+def is_from_decorator(node):
+    """Do not emit if the if has an else condition. Generally implies more complicated logic."""
+    for parent in node.node_ancestors():
+        if isinstance(parent, str): # pylint: disable=no-else-return
+            return True
+        else:
+            if parent in parent.selected_annotations:
+                return False
+            return False

tests/functional/ext/for_any_all/for_any_all.py

@@ -6,3 +6,7 @@ consider-using-any-or-all:33:4:35:23:is_from_string:`for` loop could be `any(isi
 consider-using-any-or-all:40:4:42:23:is_not_from_string:`for` loop could be `not all(isinstance(parent, str) for parent in item.parents())`:UNDEFINED
 consider-using-any-or-all:49:8:51:28:nested_check:`for` loop could be `not any(item in (1, 2, 3) for item in items)`:UNDEFINED
 consider-using-any-or-all:58:4:60:23:words_contains_word:`for` loop could be `any(word == 'word' for word in words)`:UNDEFINED
+consider-using-any-or-all:65:4:67:24:complicated_condition_check:`for` loop could be `not any(item % 2 == 0 and (item % 3 == 0 or item > 15) for item in items)`:UNDEFINED
+consider-using-any-or-all:72:4:77:23:is_from_decorator1:`for` loop could be `any(ancestor.name in ('Exception', 'BaseException') and ancestor.root().name == 'Exception' for ancestor in node)`:UNDEFINED
+consider-using-any-or-all:82:4:84:24:is_from_decorator2:`for` loop could be `all(item % 2 == 0 and (item % 3 == 0 or item > 15) for item in items)`:UNDEFINED
+consider-using-any-or-all:89:4:94:23:is_from_decorator3:`for` loop could be `not all(ancestor.name in ('Exception', 'BaseException') and ancestor.root().name == 'Exception' for ancestor in node)`:UNDEFINED