Disable fixme for internal uses before we make it optional in #3512

Author: Pierre-Sassoulas

pylint/checkers/base_checker.py

@@ -189,7 +189,7 @@ def create_message_definition_from_tuple(
             warnings.filterwarnings("ignore", category=DeprecationWarning)
             if isinstance(self, (BaseTokenChecker, BaseRawFileChecker)):
                 default_scope = WarningScope.LINE
-            # TODO: 3.0: Remove deprecated if-statement # pylint: disable=fixme
+            # TODO: 3.0: Remove deprecated if-statement
             elif implements(self, (IRawChecker, ITokenChecker)):
                 warnings.warn(  # pragma: no cover
                     "Checkers should subclass BaseTokenChecker or BaseRawFileChecker"

pylint/config/arguments_provider.py

@@ -20,7 +20,7 @@ class UnsupportedAction(Exception):
     """Raised by set_option when it doesn't know what to do for an action."""
 
     def __init__(self, *args: object) -> None:
-        # TODO: 3.0: Remove deprecated exception # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated exception
         warnings.warn(
             "UnsupportedAction has been deprecated and will be removed in pylint 3.0",
             DeprecationWarning,
@@ -50,7 +50,7 @@ def __init__(self, arguments_manager: _ArgumentsManager) -> None:
 
     @property
     def level(self) -> int:
-        # TODO: 3.0: Remove deprecated attribute # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated attribute
         warnings.warn(
             "The level attribute has been deprecated. It was used to display the checker in the help or not,"
             " and everything is displayed in the help now. It will be removed in pylint 3.0.",
@@ -60,7 +60,7 @@ def level(self) -> int:
 
     @level.setter
     def level(self, value: int) -> None:
-        # TODO: 3.0: Remove deprecated attribute # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated attribute
         warnings.warn(
             "Setting the level attribute has been deprecated. It was used to display the checker in the help or not,"
             " and everything is displayed in the help now. It will be removed in pylint 3.0.",
@@ -70,7 +70,7 @@ def level(self, value: int) -> None:
 
     @property
     def config(self) -> argparse.Namespace:
-        # TODO: 3.0: Remove deprecated attribute # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated attribute
         warnings.warn(
             "The checker-specific config attribute has been deprecated. Please use "
             "'linter.config' to access the global configuration object.",
@@ -124,7 +124,7 @@ def option_value(self, opt: str) -> Any:  # pragma: no cover
     # pylint: disable-next=unused-argument
     def set_option(self, optname, value, action=None, optdict=None):  # pragma: no cover
         """DEPRECATED: Method called to set an option (registered in the options list)."""
-        # TODO: 3.0: Remove deprecated method. # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated method.
         warnings.warn(
             "set_option has been deprecated. You can use _arguments_manager.set_option "
             "or linter.set_option to set options on the global configuration object.",

pylint/config/option.py

@@ -172,7 +172,7 @@ class Option(optparse.Option):
     TYPE_CHECKER["py_version"] = _py_version_validator
 
     def __init__(self, *opts, **attrs):
-        # TODO: 3.0: Remove deprecated class # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated class
         warnings.warn(
             "Option has been deprecated and will be removed in pylint 3.0",
             DeprecationWarning,

pylint/config/option_parser.py

@@ -19,7 +19,7 @@ def _level_options(group, outputlevel):
 
 class OptionParser(optparse.OptionParser):
     def __init__(self, option_class, *args, **kwargs):
-        # TODO: 3.0: Remove deprecated class # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated class
         warnings.warn(
             "OptionParser has been deprecated and will be removed in pylint 3.0",
             DeprecationWarning,

pylint/lint/parallel.py

@@ -56,7 +56,7 @@ def _worker_check_single_file(
     file_item: FileItem,
 ) -> tuple[
     int,
-    # TODO: 3.0: Make this only str after deprecation has been removed # pylint: disable=fixme
+    # TODO: 3.0: Make this only str after deprecation has been removed
     str | None,
     str,
     str | None,

pylint/lint/pylinter.py

@@ -235,7 +235,6 @@ def __init__(
         options: Options = (),
         reporter: reporters.BaseReporter | reporters.MultiReporter | None = None,
         option_groups: tuple[tuple[str, str], ...] = (),
-        # pylint: disable-next=fixme
         # TODO: Deprecate passing the pylintrc parameter
         pylintrc: str | None = None,  # pylint: disable=unused-argument
     ) -> None:
@@ -314,7 +313,7 @@ def __init__(
 
     @property
     def option_groups(self) -> tuple[tuple[str, str], ...]:
-        # TODO: 3.0: Remove deprecated attribute # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated attribute
         warnings.warn(
             "The option_groups attribute has been deprecated and will be removed in pylint 3.0",
             DeprecationWarning,
@@ -706,7 +705,6 @@ def check(self, files_or_modules: Sequence[str] | str) -> None:
         """
         self.initialize()
         if not isinstance(files_or_modules, (list, tuple)):
-            # pylint: disable-next=fixme
             # TODO: 3.0: Remove deprecated typing and update docstring
             warnings.warn(
                 "In pylint 3.0, the checkers check function will only accept sequence of string",
@@ -871,7 +869,7 @@ def set_current_module(
             return
         self.reporter.on_set_current_module(modname or "", filepath)
         if modname is None:
-            # TODO: 3.0: Remove all modname or ""'s in this method # pylint: disable=fixme
+            # TODO: 3.0: Remove all modname or ""'s in this method
             warnings.warn(
                 (
                     "In pylint 3.0 modname should be a string so that it can be used to "
@@ -899,7 +897,7 @@ def _astroid_module_checker(
             for c in _checkers
             if isinstance(c, checkers.BaseTokenChecker) and c is not self
         ]
-        # TODO: 3.0: Remove deprecated for-loop # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated for-loop
         for c in _checkers:
             with warnings.catch_warnings():
                 warnings.filterwarnings("ignore", category=DeprecationWarning)
@@ -918,7 +916,7 @@ def _astroid_module_checker(
         rawcheckers = [
             c for c in _checkers if isinstance(c, checkers.BaseRawFileChecker)
         ]
-        # TODO: 3.0: Remove deprecated if-statement # pylint: disable=fixme
+        # TODO: 3.0: Remove deprecated if-statement
         for c in _checkers:
             with warnings.catch_warnings():
                 warnings.filterwarnings("ignore", category=DeprecationWarning)
@@ -1006,7 +1004,7 @@ def check_astroid_module(
             ast_node, walker, rawcheckers, tokencheckers
         )
 
-        # TODO: 3.0: Remove unnecessary assertion # pylint: disable=fixme
+        # TODO: 3.0: Remove unnecessary assertion
         assert self.current_name
 
         self.stats.by_module[self.current_name]["statement"] = (

pylint/testutils/unittest_linter.py

@@ -38,7 +38,6 @@ def add_message(
         self,
         msgid: str,
         line: int | None = None,
-        # pylint: disable=fixme
         # TODO: Make node non optional
         node: nodes.NodeNG | None = None,
         args: Any = None,

pylintrc

@@ -104,6 +104,8 @@ disable=
     too-few-public-methods,
     # handled by black
     format,
+    # We anticipate #3512 where it will become optional
+    fixme,
 
 
 [REPORTS]

tests/test_self.py

@@ -253,7 +253,6 @@ def test_parallel_execution(self) -> None:
     def test_parallel_execution_missing_arguments(self) -> None:
         self._runtest(["-j 2", "not_here", "not_here_too"], code=1)
 
-    # pylint: disable-next=fixme
     # TODO: PY3.7: Turn off abbreviations in ArgumentsManager after 3.7 support has been dropped
     # argparse changed behaviour with abbreviations on/off in 3.8+ so we can't
     @pytest.mark.xfail