Added logic to check for augassign statements

Author: yushao2

pylint/checkers/refactoring/recommendation_checker.py

@@ -135,7 +135,7 @@ def _check_consider_using_enumerate(self, node: astroid.For) -> None:
                 return
 
     def _check_consider_using_dict_items(self, node: astroid.For) -> None:
-        """Emit a convention when dict key used to index dict."""
+        """Add message when accessing dict values by index lookup."""
         # Verify that we have a .keys() call and
         # that the object which is iterated is used as a subscript in the
         # body of the for.
@@ -173,8 +173,10 @@ def _check_consider_using_dict_items(self, node: astroid.For) -> None:
                     # defined and compare that to the for loop's line number
                     continue
                 if (
-                    isinstance(subscript.parent, astroid.Assign)
+                    isinstance(subscript.parent, (astroid.Assign))
                     and subscript in subscript.parent.targets
+                    or isinstance(subscript.parent, (astroid.AugAssign))
+                    and subscript == subscript.parent.target
                 ):
                     # Ignore this subscript if it is the target of an assignment
                     continue
@@ -190,7 +192,7 @@ def visit_comprehension(self, node: astroid.Comprehension) -> None:
 
         children = list(node.parent.get_children())
         if node.ifs:
-            children += node.ifs
+            children.extend(node.ifs)
         for child in children:
             for subscript in child.nodes_of_class(astroid.Subscript):
                 subscript = cast(astroid.Subscript, subscript)

tests/functional/c/consider/consider_using_dict_items.py

@@ -34,6 +34,9 @@ def another_good():
 for k2 in b_dict:  # Should not emit warning, key access necessary
     b_dict[k2] = 2
 
+for k2 in b_dict:  # Should not emit warning, key access necessary (augassign)
+    b_dict[k2] += 2
+
 # Warning should be emitted in this case
 for k6 in b_dict:  # [consider-using-dict-items]
     val = b_dict[k6]

tests/functional/c/consider/consider_using_dict_items.txt

@@ -1,13 +1,13 @@
 consider-using-dict-items:7:4:bad:Consider iterating with .items()
 consider-using-dict-items:10:4:bad:Consider iterating with .items()
 consider-using-dict-items:22:4:another_bad:Consider iterating with .items()
-consider-using-dict-items:38:0::Consider iterating with .items()
-consider-using-dict-items:42:0::Consider iterating with .items()
-consider-iterating-dictionary:45:10::Consider iterating the dictionary directly instead of calling .keys()
+consider-using-dict-items:41:0::Consider iterating with .items()
 consider-using-dict-items:45:0::Consider iterating with .items()
-consider-using-dict-items:52:0::Consider iterating with .items()
-consider-using-dict-items:56:0::Consider iterating with .items()
-consider-using-dict-items:57:0::Consider iterating with .items()
+consider-iterating-dictionary:48:10::Consider iterating the dictionary directly instead of calling .keys()
+consider-using-dict-items:48:0::Consider iterating with .items()
+consider-using-dict-items:55:0::Consider iterating with .items()
+consider-using-dict-items:59:0::Consider iterating with .items()
 consider-using-dict-items:60:0::Consider iterating with .items()
-consider-using-dict-items:61:0::Consider iterating with .items()
+consider-using-dict-items:63:0::Consider iterating with .items()
 consider-using-dict-items:64:0::Consider iterating with .items()
+consider-using-dict-items:67:0::Consider iterating with .items()