Revert adding the new checker.

Author: mbyrnepr2

doc/data/messages/n/nonlocal-defined-at-module-level/bad.py

@@ -101,9 +101,6 @@ Basic checker Messages
   Emitted when format function is not called on str object. e.g doing
   print("value: {}").format(123) instead of print("value: {}".format(123)).
   This might not be what the user intended to do.
-:nonlocal-defined-at-module-level (E0120): *nonlocal name %s defined at module level*
-  Emitted when a nonlocal variable is defined at module-level which is a
-  SyntaxError
 :nonlocal-without-binding (E0117): *nonlocal name %s found without binding*
   Emitted when a nonlocal variable does not have an attached name somewhere in
   the parent scopes

doc/data/messages/n/nonlocal-defined-at-module-level/good.py

@@ -130,7 +130,6 @@ All messages in the error category:
    error/non-iterator-returned
    error/nonexistent-operator
    error/nonlocal-and-global
-   error/nonlocal-defined-at-module-level
    error/nonlocal-without-binding
    error/not-a-mapping
    error/not-an-iterable

doc/user_guide/checkers/features.rst

@@ -1,4 +1,3 @@
 Fix a crash when a ``nonlocal`` is defined at module-level.
-Add a new checker ``nonlocal-defined-at-module-level`` when a ``nonlocal`` is defined at module-level.
 
 Closes #8735

doc/user_guide/messages/messages_overview.rst

@@ -204,12 +204,6 @@ class BasicErrorChecker(_BasicChecker):
             "which results in an error since Python 3.6.",
             {"minversion": (3, 6)},
         ),
-        "E0120": (
-            "nonlocal name %s defined at module level",
-            "nonlocal-defined-at-module-level",
-            "Emitted when a nonlocal variable is defined at module-level "
-            "which is a SyntaxError",
-        ),
     }
 
     def open(self) -> None:
@@ -402,15 +396,6 @@ def visit_unaryop(self, node: nodes.UnaryOp) -> None:
 
     def _check_nonlocal_without_binding(self, node: nodes.Nonlocal, name: str) -> None:
         current_scope = node.scope()
-        if isinstance(current_scope, nodes.Module):
-            self.add_message(
-                "nonlocal-defined-at-module-level",
-                args=(name,),
-                node=node,
-                confidence=HIGH,
-            )
-            return
-
         while current_scope.parent is not None:
             if not isinstance(current_scope, (nodes.ClassDef, nodes.FunctionDef)):
                 self.add_message("nonlocal-without-binding", args=(name,), node=node)
@@ -432,7 +417,6 @@ def _check_nonlocal_without_binding(self, node: nodes.Nonlocal, name: str) -> No
             )
 
     @utils.only_required_for_messages("nonlocal-without-binding")
-    @utils.only_required_for_messages("nonlocal-defined-at-module-level")
     def visit_nonlocal(self, node: nodes.Nonlocal) -> None:
         for name in node.names:
             self._check_nonlocal_without_binding(node, name)

doc/whatsnew/fragments/8735.other

@@ -69,3 +69,7 @@ def inner():
         myint += 1
 
     return inner()
+
+
+nonlocal APPLE  # [nonlocal-without-binding]
+APPLE = 42

pylint/checkers/base/basic_error_checker.py

@@ -2,3 +2,4 @@ nonlocal-without-binding:29:8:29:18:func.other_func:nonlocal name b found withou
 nonlocal-without-binding:35:8:35:18:func.other_func2:nonlocal name c found without binding:HIGH
 nonlocal-without-binding:40:4:40:14:SomeClass:nonlocal name x found without binding:HIGH
 nonlocal-without-binding:43:8:43:26:SomeClass.func:nonlocal name some_attr found without binding:HIGH
+nonlocal-without-binding:74:0:74:14::nonlocal name APPLE found without binding:HIGH