Remove private functions from the API of pylint.config

Author: Pierre-Sassoulas

pylint/config/__init__.py

@@ -40,23 +40,14 @@
 from pylint.config.configuration_mixin import ConfigurationMixIn
 from pylint.config.find_default_config_files import find_default_config_files
 from pylint.config.man_help_formatter import _ManHelpFormatter
-from pylint.config.option import (
-    Option,
-    _csv_validator,
-    _regexp_csv_validator,
-    _regexp_validator,
-    _validate,
-)
+from pylint.config.option import Option
 from pylint.config.option_manager_mixin import OptionsManagerMixIn
 from pylint.config.option_parser import OptionParser
 from pylint.config.options_provider_mixin import OptionsProviderMixIn, UnsupportedAction
 
 __all__ = [
     "UnsupportedAction",
     "ConfigurationMixIn",
-    "_csv_validator",
-    "_regexp_csv_validator",
-    "_regexp_validator",
     "OptionsManagerMixIn",
 ]
 

tests/unittest_config.py

@@ -23,19 +23,19 @@
 
 
 def test__regexp_validator_valid():
-    result = config._regexp_validator(None, None, "test_.*")
+    result = config.option._regexp_validator(None, None, "test_.*")
     assert isinstance(result, RE_PATTERN_TYPE)
     assert result.pattern == "test_.*"
 
 
 def test__regexp_validator_invalid():
     with pytest.raises(sre_constants.error):
-        config._regexp_validator(None, None, "test_)")
+        config.option._regexp_validator(None, None, "test_)")
 
 
 def test__csv_validator_no_spaces():
     values = ["One", "Two", "Three"]
-    result = config._csv_validator(None, None, ",".join(values))
+    result = config.option._csv_validator(None, None, ",".join(values))
     assert isinstance(result, list)
     assert len(result) == 3
     for i, value in enumerate(values):
@@ -44,7 +44,7 @@ def test__csv_validator_no_spaces():
 
 def test__csv_validator_spaces():
     values = ["One", "Two", "Three"]
-    result = config._csv_validator(None, None, ", ".join(values))
+    result = config.option._csv_validator(None, None, ", ".join(values))
     assert isinstance(result, list)
     assert len(result) == 3
     for i, value in enumerate(values):
@@ -53,7 +53,7 @@ def test__csv_validator_spaces():
 
 def test__regexp_csv_validator_valid():
     pattern_strings = ["test_.*", "foo\\.bar", "^baz$"]
-    result = config._regexp_csv_validator(None, None, ",".join(pattern_strings))
+    result = config.option._regexp_csv_validator(None, None, ",".join(pattern_strings))
     for i, regex in enumerate(result):
         assert isinstance(regex, RE_PATTERN_TYPE)
         assert regex.pattern == pattern_strings[i]
@@ -62,4 +62,4 @@ def test__regexp_csv_validator_valid():
 def test__regexp_csv_validator_invalid():
     pattern_strings = ["test_.*", "foo\\.bar", "^baz)$"]
     with pytest.raises(sre_constants.error):
-        config._regexp_csv_validator(None, None, ",".join(pattern_strings))
+        config.option._regexp_csv_validator(None, None, ",".join(pattern_strings))