Add functional tests for issue #4273

Author: Pierre-Sassoulas

tests/functional/s/string/string_formatting.py

@@ -1,8 +1,10 @@
-"""test for Python 3 string formatting error
-"""
-# pylint: disable=too-few-public-methods, import-error, unused-argument, line-too-long, no-absolute-import, useless-object-inheritance
+"""Test for Python 3 string formatting error"""
+
+# pylint: disable=too-few-public-methods, import-error, unused-argument, line-too-long, no-absolute-import,
+# pylint: disable=useless-object-inheritance
 import os
 import sys
+import logging
 from missing import Missing
 
 
@@ -11,24 +13,29 @@ class Custom(object):
     def __getattr__(self, _):
         return self
 
+
 class Test(object):
     """ test format attribute access """
     custom = Custom()
     ids = [1, 2, 3, [4, 5, 6]]
 
+
 class Getitem(object):
     """ test custom getitem for lookup access """
     def __getitem__(self, index):
         return 42
 
+
 class ReturnYes(object):
     """ can't be properly infered """
     missing = Missing()
 
+
 def log(message, message_type="error"):
     """ Test """
     return message
 
+
 def print_good():
     """ Good format strings """
     "{0} {1}".format(1, 2)
@@ -52,6 +59,9 @@ def print_good():
     "{0} {1}".format(*[1, 2])
     "{a} {b}".format(**{'a': 1, 'b': 2})
     "{a}".format(a=Missing())
+    logging.debug("%s", 42)
+    logging.debug("%s %s", 42, 43)
+
 
 def pprint_bad():
     """Test string format """
@@ -86,6 +96,9 @@ def pprint_bad():
     "{0} {a}".format(a=4) # [too-few-format-args]
     "{[0]} {}".format([4]) # [too-few-format-args]
     "{[0]} {}".format([4], 5, 6) # [too-many-format-args]
+    logging.debug("%s %s", 42) # [logging-too-few-args]
+    logging.debug("%s", 42, 43) # [logging-too-many-args]
+
 
 def good_issue288(*args, **kwargs):
     """ Test that using kwargs does not emit a false
@@ -94,6 +107,7 @@ def good_issue288(*args, **kwargs):
     'Hello John Doe {0[0]}'.format(args)
     'Hello {0[name]}'.format(kwargs)
 
+
 def good_issue287():
     """ Test that the string format checker skips
     format nodes which don't have a string as a parent
@@ -105,6 +119,7 @@ def good_issue287():
     ret['comment'] = ret['comment'].format(name)
     return ret, name
 
+
 def nested_issue294():
     """ Test nested format fields. """
     '{0:>{1}}'.format(42, 24)
@@ -115,11 +130,13 @@ def nested_issue294():
     '{0:{a[1]}}'.format(1) # [missing-format-argument-key]
     '{0:{a.x}}'.format(1, a=2) # [missing-format-attribute]
 
+
 def issue310():
     """ Test a regression using duplicate manual position arguments. """
     '{0} {1} {0}'.format(1, 2)
     '{0} {1} {0}'.format(1) # [too-few-format-args]
 
+
 def issue322():
     """ Test a regression using mixed manual position arguments
     and attribute access arguments.
@@ -128,6 +145,7 @@ def issue322():
     '{0}{1[FOO]}'.format(123, {'FOO': 456}, 321) # [too-many-format-args]
     '{0}{1[FOO]}'.format(123) # [too-few-format-args]
 
+
 def issue338():
     """
     Check that using a namedtuple subclass doesn't crash when
@@ -144,6 +162,7 @@ def __str__(self):
             return "{0.foo}: {0.bar}".format(self)
     return Crash
 
+
 def issue351():
     """
     Check that the format method can be assigned to a variable, ie:
@@ -153,6 +172,7 @@ def issue351():
     fmt('arg1', 'arg2')
     fmt('arg1', 'arg2', 'arg3') # [too-many-format-args]
 
+
 def issue373():
     """
     Ignore any object coming from an argument.
@@ -172,6 +192,7 @@ def func(self):
 
     return SomeClass
 
+
 def issue_463():
     """
     Mix positional arguments, `{0}`, with positional

tests/functional/s/string/string_formatting.txt

@@ -1,41 +1,43 @@
-too-many-format-args:58:4:pprint_bad:Too many arguments for format string
-bad-format-string:59:4:pprint_bad:Invalid format string
-bad-format-string:60:4:pprint_bad:Invalid format string
-format-combined-specification:61:4:pprint_bad:Format string contains both automatic field numbering and manual field specification
-missing-format-argument-key:63:4:pprint_bad:Missing keyword argument 'b' for format string
-unused-format-string-argument:63:4:pprint_bad:Unused format argument 'c'
-missing-format-argument-key:64:4:pprint_bad:Missing keyword argument 'a' for format string
-too-few-format-args:65:4:pprint_bad:Not enough arguments for format string
-too-many-format-args:66:4:pprint_bad:Too many arguments for format string
-missing-format-argument-key:68:4:pprint_bad:Missing keyword argument 'a' for format string
-missing-format-argument-key:68:4:pprint_bad:Missing keyword argument 'b' for format string
-missing-format-argument-key:68:4:pprint_bad:Missing keyword argument 'c' for format string
-too-few-format-args:69:4:pprint_bad:Not enough arguments for format string
-missing-format-argument-key:71:4:pprint_bad:Missing keyword argument 'a' for format string
-missing-format-argument-key:71:4:pprint_bad:Missing keyword argument 'b' for format string
-missing-format-argument-key:72:4:pprint_bad:Missing keyword argument 'a' for format string
-missing-format-attribute:74:4:pprint_bad:Missing format attribute 'length' in format specifier 'a.ids.__len__.length'
-invalid-format-index:75:4:pprint_bad:Using invalid lookup key 400 in format specifier 'a.ids[3][400]'
-invalid-format-index:76:4:pprint_bad:"Using invalid lookup key ""'string'"" in format specifier 'a.ids[3][""\'string\'""]'"
-invalid-format-index:77:4:pprint_bad:Using invalid lookup key 1 in format specifier '0[0][1]'
-invalid-format-index:78:4:pprint_bad:Using invalid lookup key 0 in format specifier '0[0][0]'
-missing-format-argument-key:80:4:pprint_bad:Missing keyword argument 'b' for format string
-unused-format-string-argument:80:4:pprint_bad:Unused format argument 'a'
-invalid-format-index:81:4:pprint_bad:Using invalid lookup key 0 in format specifier 'a[0]'
-too-many-format-args:82:8:pprint_bad:Too many arguments for format string
-missing-format-attribute:83:4:pprint_bad:Missing format attribute 'missing' in format specifier '0.missing'
-too-few-format-args:84:4:pprint_bad:Not enough arguments for format string
-too-many-format-args:85:4:pprint_bad:Too many arguments for format string
-too-few-format-args:86:4:pprint_bad:Not enough arguments for format string
-too-few-format-args:87:4:pprint_bad:Not enough arguments for format string
-too-many-format-args:88:4:pprint_bad:Too many arguments for format string
-too-few-format-args:113:4:nested_issue294:Not enough arguments for format string
-too-many-format-args:114:4:nested_issue294:Too many arguments for format string
-missing-format-argument-key:115:4:nested_issue294:Missing keyword argument 'a' for format string
-missing-format-attribute:116:4:nested_issue294:Missing format attribute 'x' in format specifier 'a.x'
-too-few-format-args:121:4:issue310:Not enough arguments for format string
-too-many-format-args:128:4:issue322:Too many arguments for format string
-too-few-format-args:129:4:issue322:Not enough arguments for format string
-too-few-format-args:152:4:issue351:Not enough arguments for format string
-too-many-format-args:154:4:issue351:Too many arguments for format string
-bad-format-string:188:11:avoid_empty_attribute:Invalid format string
+too-many-format-args:68:4:pprint_bad:Too many arguments for format string
+bad-format-string:69:4:pprint_bad:Invalid format string
+bad-format-string:70:4:pprint_bad:Invalid format string
+format-combined-specification:71:4:pprint_bad:Format string contains both automatic field numbering and manual field specification
+missing-format-argument-key:73:4:pprint_bad:Missing keyword argument 'b' for format string
+unused-format-string-argument:73:4:pprint_bad:Unused format argument 'c'
+missing-format-argument-key:74:4:pprint_bad:Missing keyword argument 'a' for format string
+too-few-format-args:75:4:pprint_bad:Not enough arguments for format string
+too-many-format-args:76:4:pprint_bad:Too many arguments for format string
+missing-format-argument-key:78:4:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-argument-key:78:4:pprint_bad:Missing keyword argument 'b' for format string
+missing-format-argument-key:78:4:pprint_bad:Missing keyword argument 'c' for format string
+too-few-format-args:79:4:pprint_bad:Not enough arguments for format string
+missing-format-argument-key:81:4:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-argument-key:81:4:pprint_bad:Missing keyword argument 'b' for format string
+missing-format-argument-key:82:4:pprint_bad:Missing keyword argument 'a' for format string
+missing-format-attribute:84:4:pprint_bad:Missing format attribute 'length' in format specifier 'a.ids.__len__.length'
+invalid-format-index:85:4:pprint_bad:Using invalid lookup key 400 in format specifier 'a.ids[3][400]'
+invalid-format-index:86:4:pprint_bad:"Using invalid lookup key ""'string'"" in format specifier 'a.ids[3][""\'string\'""]'"
+invalid-format-index:87:4:pprint_bad:Using invalid lookup key 1 in format specifier '0[0][1]'
+invalid-format-index:88:4:pprint_bad:Using invalid lookup key 0 in format specifier '0[0][0]'
+missing-format-argument-key:90:4:pprint_bad:Missing keyword argument 'b' for format string
+unused-format-string-argument:90:4:pprint_bad:Unused format argument 'a'
+invalid-format-index:91:4:pprint_bad:Using invalid lookup key 0 in format specifier 'a[0]'
+too-many-format-args:92:8:pprint_bad:Too many arguments for format string
+missing-format-attribute:93:4:pprint_bad:Missing format attribute 'missing' in format specifier '0.missing'
+too-few-format-args:94:4:pprint_bad:Not enough arguments for format string
+too-many-format-args:95:4:pprint_bad:Too many arguments for format string
+too-few-format-args:96:4:pprint_bad:Not enough arguments for format string
+too-few-format-args:97:4:pprint_bad:Not enough arguments for format string
+too-many-format-args:98:4:pprint_bad:Too many arguments for format string
+logging-too-few-args:99:4:pprint_bad:Not enough arguments for logging format string
+logging-too-many-args:100:4:pprint_bad:Too many arguments for logging format string
+too-few-format-args:128:4:nested_issue294:Not enough arguments for format string
+too-many-format-args:129:4:nested_issue294:Too many arguments for format string
+missing-format-argument-key:130:4:nested_issue294:Missing keyword argument 'a' for format string
+missing-format-attribute:131:4:nested_issue294:Missing format attribute 'x' in format specifier 'a.x'
+too-few-format-args:137:4:issue310:Not enough arguments for format string
+too-many-format-args:145:4:issue322:Too many arguments for format string
+too-few-format-args:146:4:issue322:Not enough arguments for format string
+too-few-format-args:171:4:issue351:Not enough arguments for format string
+too-many-format-args:173:4:issue351:Too many arguments for format string
+bad-format-string:209:11:avoid_empty_attribute:Invalid format string