Remove old external primer

Author: jacobtylerwalls

.github/workflows/primer-test.yaml

@@ -96,35 +96,3 @@ jobs:
           . venv/bin/activate
           pip install -e .
           pytest -m primer_stdlib --primer-stdlib -n auto -vv
-
-  pytest-primer-external-batch-one:
-    name: run on batch one / ${{ matrix.python-version }} / Linux
-    runs-on: ubuntu-latest
-    timeout-minutes: 60
-    needs: prepare-tests-linux
-    strategy:
-      matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
-    steps:
-      - name: Check out code from GitHub
-        uses: actions/[email protected]
-      - name: Set up Python ${{ matrix.python-version }}
-        id: python
-        uses: actions/[email protected]
-        with:
-          python-version: ${{ matrix.python-version }}
-          check-latest: true
-      - name: Restore Python virtual environment
-        id: cache-venv
-        uses: actions/[email protected]
-        with:
-          path: venv
-          fail-on-cache-miss: true
-          key:
-            ${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{
-            needs.prepare-tests-linux.outputs.python-key }}
-      - name: Run pytest
-        run: |
-          . venv/bin/activate
-          pip install -e .
-          pytest -m primer_external_batch_one --primer-external -n auto -vv

pyproject.toml

@@ -91,7 +91,6 @@ addopts = "--strict-markers"
 filterwarnings = "error"
 markers = [
     "primer_stdlib: Checks for crashes and errors when running pylint on stdlib",
-    "primer_external_batch_one: Checks for crashes and errors when running pylint on external libs (batch one)",
     "benchmark: Baseline of pylint performance, if this regress something serious happened",
     "timeout: Marks from pytest-timeout.",
     "needs_two_cores: Checks that need 2 or more cores to be meaningful",

tests/conftest.py

@@ -84,12 +84,6 @@ def pytest_addoption(parser: pytest.Parser) -> None:
         default=False,
         help="Run primer stdlib tests",
     )
-    parser.addoption(
-        "--primer-external",
-        action="store_true",
-        default=False,
-        help="Run primer external tests",
-    )
     parser.addoption(
         "--minimal-messages-config",
         action="store_true",
@@ -107,15 +101,6 @@ def pytest_collection_modifyitems(
     config: pytest.Config, items: list[pytest.Function]
 ) -> None:
     """Convert command line options to markers."""
-    # Add skip_primer_external mark
-    if not config.getoption("--primer-external"):
-        skip_primer_external = pytest.mark.skip(
-            reason="need --primer-external option to run"
-        )
-        for item in items:
-            if "primer_external_batch_one" in item.keywords:
-                item.add_marker(skip_primer_external)
-
     # Add skip_primer_stdlib mark
     if not config.getoption("--primer-stdlib"):
         skip_primer_stdlib = pytest.mark.skip(