Prevent causing a false negative

Author: jacobtylerwalls

pylint/checkers/variables.py

@@ -698,6 +698,13 @@ def _uncertain_nodes_in_except_blocks(
                     and closest_try_except.parent.parent_of(node_statement)
                 ):
                     uncertain_nodes.append(other_node)
+                # Or the node_statement is in the else block of the relevant TryExcept
+                elif (
+                    isinstance(node_statement.parent, nodes.TryExcept)
+                    and node_statement in node_statement.parent.orelse
+                    and closest_try_except.parent.parent_of(node_statement)
+                ):
+                    uncertain_nodes.append(other_node)
                 # Assume the except blocks execute, so long as each handler
                 # defines the name, raises, or returns.
                 elif all(

tests/functional/u/used/used_before_assignment_else_return.py

@@ -48,3 +48,14 @@ def invalid_3():
         pass
     finally:
         print(error)  # [used-before-assignment]
+
+
+def invalid_4():
+    """Should not rely on the name in the else even if it returns."""
+    try:
+        pass
+    except ValueError:
+        error = True
+    else:
+        print(error)  # [used-before-assignment]
+        return

tests/functional/u/used/used_before_assignment_else_return.txt

@@ -1,3 +1,4 @@
 used-before-assignment:25:14:25:19:invalid:Using variable 'error' before assignment:CONTROL_FLOW
 used-before-assignment:38:14:38:19:invalid_2:Using variable 'error' before assignment:CONTROL_FLOW
 used-before-assignment:50:14:50:19:invalid_3:Using variable 'error' before assignment:CONTROL_FLOW
+used-before-assignment:60:14:60:19:invalid_4:Using variable 'error' before assignment:CONTROL_FLOW