Revised codes based on review

Author: yushao2

pylint/checkers/refactoring/recommendation_checker.py

@@ -153,8 +153,9 @@ def _check_consider_using_dict_items(self, node: astroid.For) -> None:
 
                 if not isinstance(subscript.value, (astroid.Name, astroid.Attribute)):
                     continue
-
                 value = subscript.slice
+                if isinstance(value, astroid.Index):
+                    value = value.value
                 if (
                     not isinstance(value, astroid.Name)
                     or value.name != node.target.name
@@ -185,7 +186,6 @@ def visit_comprehension(self, node: astroid.Comprehension) -> None:
         iterating_object_name = utils.get_iterating_dictionary_name(node)
         if iterating_object_name is None:
             return
-
         children = list(node.parent.get_children())
         if node.ifs:
             children.extend(node.ifs)
@@ -194,8 +194,9 @@ def visit_comprehension(self, node: astroid.Comprehension) -> None:
                 subscript = cast(astroid.Subscript, subscript)
                 if not isinstance(subscript.value, (astroid.Name, astroid.Attribute)):
                     continue
-
                 value = subscript.slice
+                if isinstance(value, astroid.Index):
+                    value = value.value
                 if (
                     not isinstance(value, astroid.Name)
                     or value.name != node.target.name

pylint/checkers/utils.py

@@ -1504,20 +1504,18 @@ def get_iterating_dictionary_name(
     or a dictionary itself, this returns None.
     """
     # Is it a proper keys call?
-    if (
+    is_iterating_dict_keys = (
         isinstance(node.iter, astroid.Call)
         and isinstance(node.iter.func, astroid.Attribute)
         and node.iter.func.attrname == "keys"
-    ):
-        inferred = safe_infer(node.iter.func)
-        if not isinstance(inferred, (astroid.BoundMethod, astroid.Dict)):
-            return None
-        return node.iter.as_string().partition(".")[0]
+        and isinstance(safe_infer(node.iter.func), astroid.BoundMethod)
+    )
+    # Is it a proper dictionary?
+    is_iterating_dict = isinstance(
+        node.iter, (astroid.Name, astroid.Attribute)
+    ) and isinstance(safe_infer(node.iter), astroid.Dict)
 
-    # Is it a dictionary?
-    if not isinstance(node.iter, (astroid.Name, astroid.Attribute)):
-        return None
-    inferred = safe_infer(node.iter)
-    if not isinstance(inferred, (astroid.Dict, astroid.DictComp)):
-        return None
-    return node.iter.as_string()
+    if is_iterating_dict or is_iterating_dict_keys:
+        return node.iter.as_string().partition(".keys")[0]
+
+    return None