Fix #4045: Don't assume try ancestors are immediate parents when emitting used-before-assignment

Author: jacobtylerwalls

ChangeLog

@@ -16,6 +16,12 @@ Release date: TBA
 
   Closes #85, #2615
 
+* Fixed false negative for ``used-before-assignment`` when a conditional
+  or context manager intervened before the try statement that suggested
+  it might fail.
+
+  Closes #4045
+
 * Fixed extremely long processing of long lines with comma's.
 
   Closes #5483

doc/whatsnew/2.13.rst

@@ -63,6 +63,12 @@ Other Changes
 
   Closes #85, #2615
 
+* Fixed false negative for ``used-before-assignment`` when a conditional
+  or context manager intervened before the try statement that suggested
+  it might fail.
+
+  Closes #4045
+
 * Fix a false positive for ``assigning-non-slot`` when the slotted class
   defined ``__setattr__``.
 

pylint/checkers/variables.py

@@ -677,7 +677,7 @@ def get_next_to_consume(self, node):
 
         # If this node is in an ExceptHandler,
         # filter out assignments in the try portion, assuming they may fail
-        if found_nodes and isinstance(node_statement.parent, nodes.ExceptHandler):
+        if found_nodes:
             uncertain_nodes = (
                 self._uncertain_nodes_in_try_blocks_when_evaluating_except_blocks(
                     found_nodes, node_statement
@@ -738,17 +738,28 @@ def _uncertain_nodes_in_except_blocks(found_nodes, node, node_statement):
     def _uncertain_nodes_in_try_blocks_when_evaluating_except_blocks(
         found_nodes, node_statement
     ):
+        closest_except_handler = utils.get_node_first_ancestor_of_type(
+            node_statement, nodes.ExceptHandler
+        )
+        if closest_except_handler is None:
+            return []
+        closest_try_ancestor = utils.get_node_first_ancestor_of_type(
+            node_statement, nodes.TryExcept
+        )
         uncertain_nodes = []
         for other_node in found_nodes:
             other_node_statement = other_node.statement(future=True)
+            if other_node_statement is closest_except_handler:
+                continue
             other_node_try_ancestor = utils.get_node_first_ancestor_of_type(
                 other_node_statement, nodes.TryExcept
             )
-            if other_node_try_ancestor is None:
-                continue
-            if other_node_statement not in other_node_try_ancestor.body:
+            if other_node_try_ancestor is not closest_try_ancestor:
                 continue
-            if node_statement.parent not in other_node_try_ancestor.handlers:
+            other_node_except_handler = utils.get_node_first_ancestor_of_type(
+                other_node_statement, nodes.ExceptHandler
+            )
+            if other_node_except_handler is closest_except_handler:
                 continue
             # Passed all tests for uncertain execution
             uncertain_nodes.append(other_node)

tests/functional/u/use/used_before_assignment_issue2615.py

@@ -4,6 +4,42 @@ def main():
     try:
         res = 1 / 0
         res = 42
+        if main():
+            res = None
+        with open(__file__, encoding="utf-8") as opened_file:
+            res = opened_file.readlines()
     except ZeroDivisionError:
         print(res)  # [used-before-assignment]
     print(res)
+
+
+def nested_except_blocks():
+    """Don't confuse except blocks with each other."""
+    try:
+        res = 1 / 0
+        res = 42
+        if main():
+            res = None
+        with open(__file__, encoding="utf-8") as opened_file:
+            res = opened_file.readlines()
+    except ZeroDivisionError:
+        try:
+            more_bad_division = 1 / 0
+        except ZeroDivisionError:
+            print(more_bad_division)  # [used-before-assignment]
+            print(res)  # don't emit: too nested to make confident inferences
+    print(res)
+
+
+def name_earlier_in_except_block():
+    """Permit the name that might not have been assigned during the try block
+    to be defined inside a conditional inside the except block.
+    """
+    try:
+        res = 1 / 0
+    except ZeroDivisionError:
+        if main():
+            res = 10
+        else:
+            res = 11
+        print(res)

tests/functional/u/use/used_before_assignment_issue2615.txt

@@ -1 +1,2 @@
-used-before-assignment:8:14:8:17:main:Using variable 'res' before assignment:UNDEFINED
+used-before-assignment:12:14:12:17:main:Using variable 'res' before assignment:UNDEFINED
+used-before-assignment:29:18:29:35:nested_except_blocks:Using variable 'more_bad_division' before assignment:UNDEFINED