You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Get the msgid directly from the MessageIdStore (#5606)
We don't need to create message definitions to get their msgids.
The level of indirection may suggest we need to refactor a
little here. Maybe we actually need message definition only
when we want to display the messages.
Here's the current implementation of get_message_definitions:
def get_message_definitions(self, msgid_or_symbol: str) -> List[MessageDefinition]:
"""Returns the Message definition for either a numeric or symbolic id."""
return [
self._messages_definitions[m]
for m in self.message_id_store.get_active_msgids(msgid_or_symbol)
]
0 commit comments