applied Colin Moris patch closing #9263: no W0613 for __init__ (method does not use all of its arguments)

Author: Sylvain Thénault

checkers/variables.py

@@ -240,7 +240,7 @@ def leave_function(self, node):
                         overridden = overridden_method(klass, node.name)
                     if overridden is not None and name in overridden.argnames():
                         continue
-                    if node.name in PYMETHODS:
+                    if node.name in PYMETHODS and node.name not in ('__init__', '__new__'):
                         continue
                 # don't check callback arguments XXX should be configurable
                 if node.name.startswith('cb_') or node.name.endswith('_cb'):

test/input/func_w0613.py

@@ -22,7 +22,7 @@ def selected(cls, *args, **kwargs):
         """called by the registry when the vobject has been selected.
         """
         return cls
-    
+
     def using_inner_function(self, etype, size=1):
         """return a fake result set for a particular entity type"""
         rset = AAAA([('A',)]*size, '%s X' % etype,
@@ -33,3 +33,11 @@ def inner(row, col=0, etype=etype, req=self, rset=rset):
             return req.vreg.etype_class(etype)(req, rset, row, col)
         # pylint: disable-msg = W0201
         rset.get_entity = inner
+
+class BBBB:
+    """dummy class"""
+
+    def __init__(self, arg):
+        """Constructor with an extra parameter. Should raise a warning"""
+        self.spam = 1
+

test/messages/func_w0613.txt

@@ -2,3 +2,4 @@ W:  7:function: Unused argument 'arg'
 W: 14:AAAA.method: Unused argument 'arg'
 W: 21:AAAA.selected: Unused argument 'args'
 W: 21:AAAA.selected: Unused argument 'kwargs'
+W: 40:BBBB.__init__: Unused argument 'arg'