Remove unnecessary checks for node attributes in add_message (#5622)

Author: DanielNoord

pylint/lint/pylinter.py

@@ -1471,18 +1471,11 @@ def _add_one_message(
         if node:
             if not line:
                 line = node.fromlineno
-            # pylint: disable=fixme
-            # TODO: Initialize col_offset on every node (can be None) -> astroid
-            if not col_offset and hasattr(node, "col_offset"):
+            if not col_offset:
                 col_offset = node.col_offset
-            # pylint: disable=fixme
-            # TODO: Initialize end_lineno on every node (can be None) -> astroid
-            # See https://github.com/PyCQA/astroid/issues/1273
-            if not end_lineno and hasattr(node, "end_lineno"):
+            if not end_lineno:
                 end_lineno = node.end_lineno
-            # pylint: disable=fixme
-            # TODO: Initialize end_col_offset on every node (can be None) -> astroid
-            if not end_col_offset and hasattr(node, "end_col_offset"):
+            if not end_col_offset:
                 end_col_offset = node.end_col_offset
 
         # should this message be displayed

pylint/testutils/unittest_linter.py

@@ -43,17 +43,18 @@ def add_message(
         # If confidence is None we set it to UNDEFINED as well in PyLinter
         if confidence is None:
             confidence = UNDEFINED
-        if not line and node:
-            line = node.fromlineno
-        # pylint: disable=fixme
-        # TODO: Initialize col_offset, end_lineno and end_col_offset on every node -> astroid
-        # See https://github.com/PyCQA/astroid/issues/1273
-        if col_offset is None and node and hasattr(node, "col_offset"):
-            col_offset = node.col_offset
-        if not end_lineno and node and hasattr(node, "end_lineno"):
-            end_lineno = node.end_lineno
-        if not end_col_offset and node and hasattr(node, "end_col_offset"):
-            end_col_offset = node.end_col_offset
+
+        # Look up "location" data of node if not yet supplied
+        if node:
+            if not line:
+                line = node.fromlineno
+            if not col_offset:
+                col_offset = node.col_offset
+            if not end_lineno:
+                end_lineno = node.end_lineno
+            if not end_col_offset:
+                end_col_offset = node.end_col_offset
+
         self._messages.append(
             MessageTest(
                 msg_id,