Fix mypy errors

This commit fixes the ignoring of special methods on function overriding and also removes incorrect use of
the attribute name.

Author: ksaketou

pylint/checkers/classes.py

@@ -283,15 +283,12 @@ def _has_different_parameters(
         # check for the arguments' type
         original_type = original_param.parent.annotations[counter]
         if original_type is not None:
-            original_type = str(original_param.parent.annotations[counter].name)
-
             overridden_type = overridden_param.parent.annotations[counter]
             if overridden_type is not None:
-                overridden_type = str(overridden_param.parent.annotations[counter].name)
-                if original_type != overridden_type:
+                if original_type.name != overridden_type.name:
                     result.append(
-                        f"Parameter '{original_param.name}' was of type '{original_type}' and is now"
-                        + f" of type '{overridden_type}' in"
+                        f"Parameter '{original_param.name}' was of type '{original_type.name}' and is now"
+                        + f" of type '{overridden_type.name}' in"
                     )
             counter += 1
 
@@ -377,7 +374,7 @@ def _different_parameters(
         # unexpected-special-method-signature.
         # If the names are different, it doesn't matter, since they can't
         # be used as keyword arguments anyway.
-        different_positional =  different_kwonly = False
+        output_messages.clear()
 
     # Arguments will only violate LSP if there are variadics in the original
     # that are then removed from the overridden

tests/functional/a/arguments_differ.py

@@ -219,7 +219,8 @@ def __getitem__(self, key: int):
 
 class OverridesSpecialMethod(HasSpecialMethod):
 
-    def __getitem__(self, cheie: int): #[arguments-differ]
+    def __getitem__(self, cheie: int):
+        # no error here, method overrides special method
         return cheie + 1
 
 

tests/functional/a/arguments_differ.txt

@@ -4,5 +4,4 @@ arguments-differ:41:4:ClassmethodChild.func:Number of parameters was 2 in 'Class
 arguments-differ:68:4:VarargsChild.has_kwargs:Parameter 'arg' was of type 'bool' and is now of type 'int' in overridden 'VarargsChild.has_kwargs' method
 arguments-differ:68:4:VarargsChild.has_kwargs:Variadics removed in overridden 'VarargsChild.has_kwargs' method
 arguments-differ:71:4:VarargsChild.no_kwargs:Parameter 'args' has been renamed to 'arg' in overridden 'VarargsChild.no_kwargs' method
-arguments-differ:172:4:SecondChangesArgs.test:Number of parameters was 2 in 'FirstHasArgs.test' and is now 4 in overridden 'SecondChangesArgs.test' method
-arguments-differ:222:4:OverridesSpecialMethod.__getitem__:Parameter 'key' has been renamed to 'cheie' in overridden 'OverridesSpecialMethod.__getitem__' method
+arguments-differ:172:4:SecondChangesArgs.test:Number of parameters was 2 in 'FirstHasArgs.test' and is now 4 in overridden 'SecondChangesArgs.test' method