Use argparse config handler on two checkers (#6120)

Author: DanielNoord

pylint/checkers/strings.py

@@ -677,8 +677,8 @@ class StringConstantChecker(BaseTokenChecker):
     # Unicode strings.
     UNICODE_ESCAPE_CHARACTERS = "uUN"
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
+    def __init__(self, linter):
+        super().__init__(linter, future_option_parsing=True)
         self.string_tokens = {}  # token position -> (token value, next token)
 
     def process_module(self, node: nodes.Module) -> None:
@@ -709,7 +709,7 @@ def process_tokens(self, tokens):
                     start = (start[0], len(line[: start[1]].encode(encoding)))
                 self.string_tokens[start] = (str_eval(token), next_token)
 
-        if self.config.check_quote_consistency:
+        if self.linter.namespace.check_quote_consistency:
             self.check_for_consistent_string_delimiters(tokens)
 
     @check_messages("implicit-str-concat")
@@ -783,7 +783,7 @@ def check_for_concatenated_strings(self, elements, iterable_type):
             if matching_token != elt.value and next_token is not None:
                 if next_token.type == tokenize.STRING and (
                     next_token.start[0] == elt.lineno
-                    or self.config.check_str_concat_over_line_jumps
+                    or self.linter.namespace.check_str_concat_over_line_jumps
                 ):
                     self.add_message(
                         "implicit-str-concat", line=elt.lineno, args=(iterable_type,)

pylint/checkers/typecheck.py

@@ -883,6 +883,9 @@ class TypeChecker(BaseChecker):
         ),
     )
 
+    def __init__(self, linter: "PyLinter") -> None:
+        super().__init__(linter, future_option_parsing=True)
+
     def open(self) -> None:
         py_version = get_global_option(self, "py-version")
         self._py310_plus = py_version >= (3, 10)
@@ -899,7 +902,7 @@ def _compiled_generated_members(self) -> Tuple[Pattern, ...]:
         # (surrounded by quote `"` and followed by a comma `,`)
         # REQUEST,aq_parent,"[a-zA-Z]+_set{1,2}"' =>
         # ('REQUEST', 'aq_parent', '[a-zA-Z]+_set{1,2}')
-        generated_members = self.config.generated_members
+        generated_members = self.linter.namespace.generated_members
         if isinstance(generated_members, str):
             gen = shlex.shlex(generated_members)
             gen.whitespace += ","
@@ -986,7 +989,7 @@ def visit_attribute(self, node: nodes.Attribute) -> None:
         ]
         if (
             len(non_opaque_inference_results) != len(inferred)
-            and self.config.ignore_on_opaque_inference
+            and self.linter.namespace.ignore_on_opaque_inference
         ):
             # There is an ambiguity in the inference. Since we can't
             # make sure that we won't emit a false positive, we just stop
@@ -995,7 +998,10 @@ def visit_attribute(self, node: nodes.Attribute) -> None:
         for owner in non_opaque_inference_results:
             name = getattr(owner, "name", None)
             if _is_owner_ignored(
-                owner, name, self.config.ignored_classes, self.config.ignored_modules
+                owner,
+                name,
+                self.linter.namespace.ignored_classes,
+                self.linter.namespace.ignored_modules,
             ):
                 continue
 
@@ -1024,8 +1030,8 @@ def visit_attribute(self, node: nodes.Attribute) -> None:
                     owner,
                     name,
                     self._mixin_class_rgx,
-                    ignored_mixins=self.config.ignore_mixin_members,
-                    ignored_none=self.config.ignore_none,
+                    ignored_mixins=self.linter.namespace.ignore_mixin_members,
+                    ignored_none=self.linter.namespace.ignore_none,
                 ):
                     continue
                 missingattr.add((owner, name))
@@ -1080,12 +1086,12 @@ def _get_nomember_msgid_hint(self, node, owner):
             hint = ""
         else:
             msg = "no-member"
-            if self.config.missing_member_hint:
+            if self.linter.namespace.missing_member_hint:
                 hint = _missing_member_hint(
                     owner,
                     node.attrname,
-                    self.config.missing_member_hint_distance,
-                    self.config.missing_member_max_choices,
+                    self.linter.namespace.missing_member_hint_distance,
+                    self.linter.namespace.missing_member_max_choices,
                 )
             else:
                 hint = ""
@@ -1335,7 +1341,7 @@ def visit_call(self, node: nodes.Call) -> None:
 
         # Has the function signature changed in ways we cannot reliably detect?
         if hasattr(called, "decorators") and decorated_with(
-            called, self.config.signature_mutators
+            called, self.linter.namespace.signature_mutators
         ):
             return
 
@@ -1709,7 +1715,7 @@ def visit_with(self, node: nodes.With) -> None:
                 # Check if we are dealing with a function decorated
                 # with contextlib.contextmanager.
                 if decorated_with(
-                    inferred.parent, self.config.contextmanager_decorators
+                    inferred.parent, self.linter.namespace.contextmanager_decorators
                 ):
                     continue
                 # If the parent of the generator is not the context manager itself,
@@ -1737,7 +1743,9 @@ def visit_with(self, node: nodes.With) -> None:
                     scope = inferred_path.scope()
                     if not isinstance(scope, nodes.FunctionDef):
                         continue
-                    if decorated_with(scope, self.config.contextmanager_decorators):
+                    if decorated_with(
+                        scope, self.linter.namespace.contextmanager_decorators
+                    ):
                         break
                 else:
                     self.add_message(
@@ -1754,7 +1762,7 @@ def visit_with(self, node: nodes.With) -> None:
                         if not has_known_bases(inferred):
                             continue
                         # Just ignore mixin classes.
-                        if self.config.ignore_mixin_members:
+                        if self.linter.namespace.ignore_mixin_members:
                             if inferred.name[-5:].lower() == "mixin":
                                 continue
 
@@ -1999,6 +2007,9 @@ class IterableChecker(BaseChecker):
         ),
     }
 
+    def __init__(self, linter: "PyLinter") -> None:
+        super().__init__(linter, future_option_parsing=True)
+
     @staticmethod
     def _is_asyncio_coroutine(node):
         if not isinstance(node, nodes.Call):

pylint/config/arguments_manager.py

@@ -22,7 +22,7 @@ def __init__(self) -> None:
         self.namespace = argparse.Namespace()
         """Namespace for all options."""
 
-        self._arg_parser = argparse.ArgumentParser(prog="pylint")
+        self._arg_parser = argparse.ArgumentParser(prog="pylint", allow_abbrev=False)
         """The command line argument parser."""
 
         self._argument_groups_dict: Dict[str, argparse._ArgumentGroup] = {}