Skip to content

Remove option definitions from Configuration object. #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AWhetter opened this issue Feb 18, 2018 · 1 comment
Closed

Remove option definitions from Configuration object. #1888

AWhetter opened this issue Feb 18, 2018 · 1 comment
Labels
Help wanted 🙏 Outside help would be appreciated, good for new contributors Per directory config New per directory config feature

Comments

@AWhetter
Copy link
Contributor

Really the ConfigParser objects are responsible for setting the correct value type and on the correct destination, so a Configuration shouldn't need the option definitions. It can do it's merging using __dict__ instead, so it'll behave a bit more like an argparse.Namespace.
@AWhetter AWhetter added Help wanted 🙏 Outside help would be appreciated, good for new contributors Per directory config New per directory config feature labels Feb 18, 2018
@AWhetter
Copy link
Contributor Author

Closing in favour of #2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted 🙏 Outside help would be appreciated, good for new contributors Per directory config New per directory config feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AWhetter