Skip to content

Rename extension-pkg-whitelist to extension-pkg-allow-list #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashb opened this issue Jun 7, 2020 · 2 comments · Fixed by #3961
Closed

Rename extension-pkg-whitelist to extension-pkg-allow-list #3669

ashb opened this issue Jun 7, 2020 · 2 comments · Fixed by #3961
Labels
Enhancement ✨ Improvement to a component

Comments

@ashb
Copy link

ashb commented Jun 7, 2020

Language matters. I'd like to remove all references in Apache Airflow to white list or black list and I found an occurance in our pylintrc file.

The recent global events have made this even more relevant, Here is a well written article for why I think it matters

https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white

It's fairly common to say whitelisting and blacklisting to describe desirable and undesirable things in cyber security.

However, there's an issue with the terminology. It only makes sense if you equate white with 'good, permitted, safe' and black with 'bad, dangerous, forbidden'. There are some obvious problems with this.

You may not see why this matters. If you're not adversely affected by racial stereotyping yourself, then please count yourself lucky. For some of our colleagues and users (and potential future colleagues), this really is a change worth making.

It is possible to make this change in a backwards-compatible fashion (update the docs to use new string, have code look at new and old string when reading rc file) and is clearer too.

@illume
Copy link

illume commented Nov 16, 2020

Hellos 👋

Will a PR for this be accepted? Happy to help :)

I guess we would need to support extension-pkg-whitelist for backwards compatibility?

@pkolbus
Copy link
Contributor

pkolbus commented Nov 22, 2020

I'd really appreciate seeing this as well. Fostering a welcoming environment matters, and this is one way to help that. And aside from the racial stereotypes, I'll second the notion that clearer terms make it easier for everyone to understand, including those for whom English is not a first language.

I would also note:

  • There is also use of the term "blacklist" in the description of ignore and ignore-patterns.
  • Master/slave is another pair of terms that also has racial connotations, especially because of United States history -- master is at least a pylintrc section name, so this would also need backwards compatibility work. Perhaps main or global is better here?

I'm also happy to help make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants