Skip to content

Option to enable all useless-suppression warnings #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jacobtylerwalls opened this issue Mar 11, 2022 · 2 comments
Open

Option to enable all useless-suppression warnings #5898

jacobtylerwalls opened this issue Mar 11, 2022 · 2 comments
Labels
Enhancement ✨ Improvement to a component Help wanted 🙏 Outside help would be appreciated, good for new contributors Needs PR This issue is accepted, sufficiently specified and now needs an implementation

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Mar 11, 2022 •
edited
Loading

Current problem

useless-suppression doesn't warn about cyclic-import and deprecated-{module|argument|class|method|decorator}. (See the constant INCOMPATIBLE_WITH_USELESS_SUPPRESSION.) Some users might want to see these warnings anyway.

Desired solution

Provide a configuration option to enable every useless suppression warning. It shouldn't be on by default.

Additional context

Proposed here #5876 (comment)
@jacobtylerwalls jacobtylerwalls added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Mar 11, 2022
@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component Help wanted 🙏 Outside help would be appreciated, good for new contributors and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Mar 11, 2022
@gajanangitte
Copy link

Hey, I would like to work on this issue

@Pierre-Sassoulas
Copy link
Member

Thank you @gajanangitte I assigned you to the issue. Be warned though that this might not be as easy as it look. Also I think you should do deprecated-x first, then cyclic-import :)

@Pierre-Sassoulas Pierre-Sassoulas added the Needs PR This issue is accepted, sufficiently specified and now needs an implementation label Jun 24, 2022
@jacobtylerwalls jacobtylerwalls mentioned this issue Jul 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component Help wanted 🙏 Outside help would be appreciated, good for new contributors Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Pierre-Sassoulas @DanielNoord @jacobtylerwalls @gajanangitte