check_parallel does not restore sys.path to the original value

[jacobtylerwalls]

check_parallel does not restore sys.path to the original value.

Discovered while working on #7117, but unrelated to the issue it tested.

Opening an issue purely for the sake of satisfying the towncrier pre-commit check, which requires issues for all bugfixes.

[Pierre-Sassoulas]

Opening an issue purely for the sake of satisfying the towncrier pre-commit check

Can't we use the PR number ?

[jacobtylerwalls]

I wondered, but we may not even merge #7117, and it was just a "found while developing" issue, not really related to it.

[Pierre-Sassoulas]

I meant the number of the PR we open to fix the issue in this case #7247 (we do need to open it then create the towncrier fragment or hope for no other issue/PR to be opened before we create ours though).

[jacobtylerwalls]

But then I have to no-verify my changes to get them up to Github. Opening an issue seemed lower friction.

[Pierre-Sassoulas]

I have to no-verify my change

Is there a towncrier pre-commit check ? I often forgot to add the fragment myself I'd like this 😄

[jacobtylerwalls]

Check newsfragments......................................................Failed
- hook id: check-newsfragments
- exit code: 1

doc/whatsnew/fragments/slug.bugfix: does not respect the standard format 🤖👎

The standard format is:

<one or more line of text>
<one blank line>
<issue reference> #<issuenumber>

Where <issue reference> can be one of: Refs, Closes, Follow-up in, Fixes part of

For example:

``pylint.x.y`` is now a private API.

Refs #1234

[jacobtylerwalls]

Added in 54e54ad

[Pierre-Sassoulas]

Ha right, but this does not check that the number is an issue or that it actually exists in github, only that the format is standard. So I think you can "cheat" 😄 (Or that there is a new fragment for your branch compared to main)

[jacobtylerwalls]

Where can be one of: Refs, Closes, Follow-up in, Fixes part of

"Fixes part of too lazy to open an issue" 🤣

[Pierre-Sassoulas]

"Fixes part of too lazy to open an issue" 🤣

🤣

It's funny because it's true. I'm pretty sure 50% of the time when I "reference" something it means this is a lazy pull request with no attached issue 😄

[DudeNr33]

The pre-commit check only triggers if you have created a new file in the newsfragments folder.
You can use the PR number if you'd like, but you will have to push at least twice (as you don't know the PR number beforehand).

I'm open to ideas how to improve this! 😊

[Pierre-Sassoulas]

It was mostly just a discussion on the benefit of creating a small issue vs a two stage PR, both are fine and we don't need to change anything imo.