False positive no-name-in-module(E0611) in module nh3

[jasperfirecai2]

Bug description

Intellisense can resolve this module import but pylint claims this not to not exist. nh3 has no pylint-plugin as it shouldn't need one. issue on their repo

Configuration

No response

Command used

pylint.exe --reports=n --output-format=json --rcfile=.pylintrc --from-stdin [...]/a.py

via pylint vscode plugin
OR

python -m pylint --rcfile=.pylintrc $(git ls-files '*.py')

Pylint output

************* Module a
a.py:19:0: E0611: No name 'clean' in module 'nh3' (no-name-in-module)

Expected behavior

There should be no linter warning here since the module resolves in both intellisense and code.

Pylint version

Legacy version because vscode plugin used to be broken

pylint 2.13.4
astroid 2.11.7
Python 3.9.1

Also applies to newer version

pylint 2.17.4
astroid 2.15.5
Python 3.9.1

OS / Environment

Windows 10 Enterprise 64-bit
vscode builtin terminal

Additional dependencies

for specific issue:
nh3==0.2.13

within project:
pylint-django==2.5.3
pylint-plugin-utils==0.8.2

[mbyrnepr2]

Thanks @jasperfirecai2. I think this is the same situation as #6281.
nh3 is Rust but it does have a pyi file which we could potentially start checking.

[jasperfirecai2]

nh3 is a wrapper for ammonia, which is written in rust aye

[Zedifuu]

We are also experiencing this in our project, We have put in temporary exclusions for now and will monitor this thread for any changes. https://gitlab.com/crafty-controller/crafty-4/-/commit/ef691eda5c37ae0267cfd99d7d4c48f75d37d984

[Pierre-Sassoulas]

It seems like it's a duplicate of #4987 (pyi support), and should be fixed. Are you using pylint 3 or more, and are you providing the pyi to pylint ? (Disclaimer: I'm not using pyi myself so I don't know for sure if it works, but it should).

[Zedifuu]

Hi there,

Thank you for the rapid response, It's appreciated.
I'm not sure what you mean by pyi, All we've done is a standard install of nh3, use it in our application and then proceed to get the pylint findings, no extra pylint configuration has been applied for nh3.

nh3 0.2.14
Python 3.12.1
pip 23.2.1
pylint 3.0.3
astroid 3.0.2
pylint-gitlab 2.0.0

[Pierre-Sassoulas]

nh3 is Rust but it does have a pyi file which we could potentially start checking.

pylint will need this pyi file to understand the rust code that it can't analyses. (Until recently it couldn't analyses the pyi file either). Or an inference tip that we call brain and that is more internal that that and that we call astroid brain, basically it would mean a pylint plugin for nh3.

[Zedifuu]

Oh that's super interesting I also love the naming of asteroid brain 🤩🧠

OK so I had a root around the nh3 package contents for the pyi file and did indeed find something promising. However how would I would direct pylint to this file to use it ? Is there configuration in the pylintrc?

Apologies if I am referencing something that has already been asked if there is documentation please direct me 😅

[Pierre-Sassoulas]

I would make sure that the pyi is accessible by pylint (with the proper namespace like in nh3/__init__.py). I think what you have should work it seems it's in your virtual env or local install..

[Zedifuu]

Indeed the installation is pretty standard and set up in a virtual environment so I'm kind of stumped in why pylint isn't able to parse nh3 properly, And just checking there definitely isn't any place in the configuration to direct pylint with paths to these kind of files?

[jacobtylerwalls]

@Pierre-Sassoulas I think for .pyi support we also need #9097, fixed in #9241, waiting on astroid 3.1.

[Zedifuu]

Ahh gocha thank you both for the updates <3

[Pierre-Sassoulas]

I'm going to try to release astroid 3.1.0 asap then.