From 7d851b5bf8ffe3ed68db94444f7e2c1de5c0c8bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 30 Dec 2021 10:27:17 +0100 Subject: [PATCH 1/3] Update CACHE_VERSION of primer, add comment and update paths --- .github/workflows/ci.yaml | 2 +- .github/workflows/primer-test.yaml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e0eeef0793..a729858796 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ on: pull_request: ~ env: - CACHE_VERSION: 4 + CACHE_VERSION: 4 # Also change this in the primer workflow DEFAULT_PYTHON: 3.8 PRE_COMMIT_CACHE: ~/.cache/pre-commit diff --git a/.github/workflows/primer-test.yaml b/.github/workflows/primer-test.yaml index 08e9d125d4..d7baf213f1 100644 --- a/.github/workflows/primer-test.yaml +++ b/.github/workflows/primer-test.yaml @@ -10,9 +10,10 @@ on: - "pylint/**" - "tests/primer/**" - "requirements*" + - ".github/workflows/primer-test.yaml" env: - CACHE_VERSION: 3 + CACHE_VERSION: 4 # Also change this in the CI workflow concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} From 6c1df0ab5eba5b5c5ecad6aedde66b6a92435dae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 30 Dec 2021 13:52:52 +0100 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> --- .github/workflows/ci.yaml | 2 +- .github/workflows/primer-test.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a729858796..55b520a920 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ on: pull_request: ~ env: - CACHE_VERSION: 4 # Also change this in the primer workflow + CACHE_VERSION: 4 # Also change this in the primer workflow DEFAULT_PYTHON: 3.8 PRE_COMMIT_CACHE: ~/.cache/pre-commit diff --git a/.github/workflows/primer-test.yaml b/.github/workflows/primer-test.yaml index d7baf213f1..8de1d81bc8 100644 --- a/.github/workflows/primer-test.yaml +++ b/.github/workflows/primer-test.yaml @@ -13,7 +13,7 @@ on: - ".github/workflows/primer-test.yaml" env: - CACHE_VERSION: 4 # Also change this in the CI workflow + CACHE_VERSION: 4 # Also change this in the CI workflow concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} From e3953e9572dc7574db54f968c974417b2c95ae70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Noord?= <13665637+DanielNoord@users.noreply.github.com> Date: Thu, 30 Dec 2021 14:00:03 +0100 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> --- .github/workflows/ci.yaml | 3 ++- .github/workflows/primer-test.yaml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 55b520a920..4a2118b16e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,8 @@ on: pull_request: ~ env: - CACHE_VERSION: 4 # Also change this in the primer workflow + # Also change CACHE_VERSION in the primer workflow + CACHE_VERSION: 4 DEFAULT_PYTHON: 3.8 PRE_COMMIT_CACHE: ~/.cache/pre-commit diff --git a/.github/workflows/primer-test.yaml b/.github/workflows/primer-test.yaml index 8de1d81bc8..54ee542821 100644 --- a/.github/workflows/primer-test.yaml +++ b/.github/workflows/primer-test.yaml @@ -13,7 +13,8 @@ on: - ".github/workflows/primer-test.yaml" env: - CACHE_VERSION: 4 # Also change this in the CI workflow + # Also change CACHE_VERSION in the CI workflow + CACHE_VERSION: 4 concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}