From 5a240dfdc428ed8d56ea93674d834e9ee43aeedc Mon Sep 17 00:00:00 2001 From: harupy Date: Mon, 6 Jun 2022 17:46:22 +0900 Subject: [PATCH 1/2] Add implicit-str-concat example --- doc/data/messages/i/implicit-str-concat/bad.py | 1 + doc/data/messages/i/implicit-str-concat/details.rst | 1 - doc/data/messages/i/implicit-str-concat/good.py | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 doc/data/messages/i/implicit-str-concat/bad.py delete mode 100644 doc/data/messages/i/implicit-str-concat/details.rst diff --git a/doc/data/messages/i/implicit-str-concat/bad.py b/doc/data/messages/i/implicit-str-concat/bad.py new file mode 100644 index 0000000000..8d3180e159 --- /dev/null +++ b/doc/data/messages/i/implicit-str-concat/bad.py @@ -0,0 +1 @@ +x = ["a" "b"] # [implicit-str-concat] diff --git a/doc/data/messages/i/implicit-str-concat/details.rst b/doc/data/messages/i/implicit-str-concat/details.rst deleted file mode 100644 index ab82045295..0000000000 --- a/doc/data/messages/i/implicit-str-concat/details.rst +++ /dev/null @@ -1 +0,0 @@ -You can help us make the doc better `by contributing `_ ! diff --git a/doc/data/messages/i/implicit-str-concat/good.py b/doc/data/messages/i/implicit-str-concat/good.py index c40beb573f..54572735ec 100644 --- a/doc/data/messages/i/implicit-str-concat/good.py +++ b/doc/data/messages/i/implicit-str-concat/good.py @@ -1 +1 @@ -# This is a placeholder for correct code for this message. +x = ["a", "b"] From dce98728deef415785e700571e7c10f2a47cbbf6 Mon Sep 17 00:00:00 2001 From: Harutaka Kawamura Date: Mon, 6 Jun 2022 17:56:48 +0900 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Pierre Sassoulas --- doc/data/messages/i/implicit-str-concat/bad.py | 3 +++ doc/data/messages/i/implicit-str-concat/good.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/doc/data/messages/i/implicit-str-concat/bad.py b/doc/data/messages/i/implicit-str-concat/bad.py index 8d3180e159..815b70976a 100644 --- a/doc/data/messages/i/implicit-str-concat/bad.py +++ b/doc/data/messages/i/implicit-str-concat/bad.py @@ -1 +1,4 @@ x = ["a" "b"] # [implicit-str-concat] + +with open("hello.txt" "r") as f: # [implicit-str-concat] + print(f.read()) diff --git a/doc/data/messages/i/implicit-str-concat/good.py b/doc/data/messages/i/implicit-str-concat/good.py index 54572735ec..ebf50c7471 100644 --- a/doc/data/messages/i/implicit-str-concat/good.py +++ b/doc/data/messages/i/implicit-str-concat/good.py @@ -1 +1,4 @@ x = ["a", "b"] + +with open("hello.txt", "r") as f: + print(f.read())