From 9c21bfab87684c1aeb43070e312581c78338cd03 Mon Sep 17 00:00:00 2001 From: Jacob Walls Date: Wed, 8 Jun 2022 13:30:32 -0400 Subject: [PATCH 1/2] don't duplicate --rcfile arg --- tests/primer/primer_tool.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/primer/primer_tool.py b/tests/primer/primer_tool.py index 2a94dfb559..ae8ca90d14 100644 --- a/tests/primer/primer_tool.py +++ b/tests/primer/primer_tool.py @@ -292,8 +292,6 @@ def _lint_package(self, data: PackageToLint) -> list[dict[str, str | int]]: # TODO: Find a way to allow cyclic-import and compare output correctly disables = ["--disable=duplicate-code,cyclic-import"] arguments = data.pylint_args + enables + disables - if data.pylintrc_relpath: - arguments += [f"--rcfile={data.pylintrc_relpath}"] output = StringIO() reporter = JSONReporter(output) Run(arguments, reporter=reporter, exit=False) From 5b6f229899e6692c338625400623cbbdd340658b Mon Sep 17 00:00:00 2001 From: Jacob Walls Date: Thu, 9 Jun 2022 11:56:08 -0400 Subject: [PATCH 2/2] Add missing space to primer comment --- tests/primer/primer_tool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/primer/primer_tool.py b/tests/primer/primer_tool.py index ae8ca90d14..8f6660916a 100644 --- a/tests/primer/primer_tool.py +++ b/tests/primer/primer_tool.py @@ -273,7 +273,7 @@ def _create_comment( if len(comment) + len(hash_information) >= MAX_GITHUB_COMMENT_LENGTH: truncation_information = ( f"*This comment was truncated because GitHub allows only" - f"{MAX_GITHUB_COMMENT_LENGTH} characters in a comment.*" + f" {MAX_GITHUB_COMMENT_LENGTH} characters in a comment.*" ) max_len = ( MAX_GITHUB_COMMENT_LENGTH