Skip to content

GLM hierarchical #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Mar 30, 2021 · 5 comments
Closed

GLM hierarchical #80

OriolAbril opened this issue Mar 30, 2021 · 5 comments
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

OriolAbril commented Mar 30, 2021

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-hierarchical.ipynb
Reviewers: @twiecki

The sections below may still be pending. If so, the issue is still available, it simply doesn't have specific guidance yet. Please refer to this overview of updates

Known changes needed

Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.

General updates

ArviZ related

  • use return_inferencedata=True
  • update slope plotting code
    • use idata and xarray. ⚠️ first operate, then average, the sum of averages is not necessarily the average of the sum.
    • be careful with zorder, alpha and linestyles, markers... to ensure the plot is easy to read for everyone and conveys the relevant information.

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.

General updates

  • This references the multilevel modeling notebook both as general document and specific cells! ⚠️ with hardcoded links and cell numbers. We should define anchors back in multilevel modeling and use those anchors here. This may be possible in nbsphinx, but I'd say this is a motive to move to myst-nb where it's natural to use rst directives from markdown.

Notes

Exotic dependencies

None

Computing requirements

@OriolAbril OriolAbril added the tracker id Issues used as trackers in the notebook update project, do not close! label Mar 30, 2021
@OriolAbril OriolAbril added the high impact Notebooks with most visits on docs.pymc.io label Apr 7, 2021
@chiral-carbon
Copy link
Collaborator

Hi! I would like to take up this issue.

@OriolAbril
Copy link
Member Author

Sorry about the bad tracking in this case @chiral-carbon, there was already a PR open for that but it wasn't properly linked, you can help reviewing the PR if you are interested in this specific notebook, the more eyes the better 😄

@chiral-carbon
Copy link
Collaborator

chiral-carbon commented May 4, 2021

oh okay, no worries! sure, if I have anything substantive to add, I'll do that!

@reshamas
Copy link
Contributor

I will work on this notebook.

@OriolAbril
Copy link
Member Author

This notebook has been deleted and superseeded by https://www.pymc.io/projects/examples/en/latest/case_studies/multilevel_modeling.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact Notebooks with most visits on docs.pymc.io tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

3 participants