Skip to content

Fix: all links in MLDA Intro Page #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

pseudo-nerd
Copy link
Contributor

@pseudo-nerd pseudo-nerd commented Jul 31, 2024

Fix: Update Broken Links in MLDA Sampler Introduction Page

Summary
solving issue #682
This PR addresses two broken links in the MLDA (Multilevel Delayed Acceptance) sampler introduction and resources page.

Description
Two links in the MLDA sampler introduction page were pointing to non-existent locations. This PR updates these links to their correct destinations, ensuring users can access the intended resources.

Changes Made

  • Updated the link for MLDA benchmarks and tuning notebook
  • Updated the link for MLDA adaptive error model notebook

Details of Fixed Links

  1. MLDA benchmarks and tuning notebook:

  2. MLDA adaptive error model notebook:

Also I have updated the links in both .md and .ipynb file.

Please review the changes and merge it if all looks good. Thank you!


📚 Documentation preview 📚: https://pymc-examples--683.org.readthedocs.build/en/683/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriolAbril
Copy link
Member

This PR includes the non-sensical code from #681.

@pseudo-nerd
Copy link
Contributor Author

pseudo-nerd commented Aug 1, 2024

Hii @OriolAbril ,
Sorry for the confusion, I have updated the commit and removed the unneccesary code.
Please review it and let me know if any more changes are needed.
Thanks!

@pseudo-nerd pseudo-nerd changed the title Fixed All links in MLDA Intro Page Fix: all links in MLDA Intro Page Aug 2, 2024
@twiecki twiecki merged commit 7c9d1d2 into pymc-devs:main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants