Skip to content

Commit 7dcb67c

Browse files
committed
Revert removed xfail
1 parent 83014e8 commit 7dcb67c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

pymc3/tests/test_distributions.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -885,8 +885,10 @@ def test_chi_squared(self):
885885
lambda value, nu: sp.chi2.logpdf(value, df=nu),
886886
)
887887

888-
# TODO: Is this still needed? It passes locally.
889-
# @pytest.mark.xfail(reason="Poor CDF in SciPy. See scipy/scipy#869 for details.")
888+
@pytest.mark.xfail(
889+
condition=(theano.config.floatX == "float32"),
890+
reason="Poor CDF in SciPy. See scipy/scipy#869 for details.",
891+
)
890892
def test_wald_scipy(self):
891893
self.pymc3_matches_scipy(
892894
Wald,
@@ -1178,7 +1180,7 @@ def test_fun(value, mu, sigma):
11781180
Rplus,
11791181
{"alpha": Rplusbig, "beta": Rplusbig},
11801182
lambda value, alpha, beta: sp.gamma.logcdf(value, alpha, scale=1.0 / beta),
1181-
skip_paramdomain_outside_edge_test=True, # TODO: This is failing mysteriously
1183+
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
11821184
)
11831185

11841186
@pytest.mark.xfail(
@@ -1197,7 +1199,7 @@ def test_inverse_gamma(self):
11971199
Rplus,
11981200
{"alpha": Rplus, "beta": Rplus},
11991201
lambda value, alpha, beta: sp.invgamma.logcdf(value, alpha, scale=beta),
1200-
skip_paramdomain_outside_edge_test=True, # TODO: This is failing mysteriously
1202+
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
12011203
)
12021204

12031205
@pytest.mark.xfail(

0 commit comments

Comments
 (0)