Skip to content

Commit 97adc62

Browse files
committed
Remove float128 dtype
Backport of #4514. Removes float128 dtype which does not exist on Windows and newer OSX versions and furthermore does not to be properly supported even if it does exist.
1 parent e07a71a commit 97adc62

File tree

3 files changed

+5
-19
lines changed

3 files changed

+5
-19
lines changed

Diff for: RELEASE-NOTES.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
+ A deprecation warning from the `semver` package we use for checking backend compatibility was dealt with (see [#4547](https://github.com/pymc-devs/pymc3/pull/4547)).
66
+ `theano.printing.pydotprint` is now hotfixed upon import (see [#4594](https://github.com/pymc-devs/pymc3/pull/4594)).
77
+ Fix bug in the computation of the log pseudolikelihood values (SMC-ABC). (see [#4672](https://github.com/pymc-devs/pymc3/pull/4672)).
8-
+ Fix `LKJCorr.random` method to work with `pm.sample_prior_predictive`. (see [#4780](https://github.com/pymc-devs/pymc3/pull/4780))
8+
+ Fix `LKJCorr.random` method to work with `pm.sample_prior_predictive`. (see [#4780](https://github.com/pymc-devs/pymc3/pull/4780)).
99
+ Enable documentation generation via ReadTheDocs for upcoming v3 releases. (see [#4805](https://github.com/pymc-devs/pymc3/pull/4805)).
10+
+ Remove `float128` dtype support (see [#4834](https://github.com/pymc-devs/pymc3/pull/4834)).
1011

1112
### New Features
1213
+ Generalized BART, bounded distributions like Binomial and Poisson can now be used as likelihoods (see [#4675](https://github.com/pymc-devs/pymc3/pull/4675), [#4709](https://github.com/pymc-devs/pymc3/pull/4709) and

Diff for: pymc3/distributions/dist_math.py

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2020 The PyMC Developers
1+
# Copyright 2021 The PyMC Developers
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -17,8 +17,6 @@
1717
1818
@author: johnsalvatier
1919
"""
20-
import platform
21-
2220
import numpy as np
2321
import scipy.linalg
2422
import scipy.stats
@@ -44,11 +42,6 @@
4442
dtype: (np.nextafter(0, 1, dtype=dtype), np.nextafter(1, 0, dtype=dtype))
4543
for dtype in ["float16", "float32", "float64"]
4644
}
47-
if platform.system() in ["Linux", "Darwin"]:
48-
_beta_clip_values["float128"] = (
49-
np.nextafter(0, 1, dtype="float128"),
50-
np.nextafter(1, 0, dtype="float128"),
51-
)
5245

5346

5447
def bound(logp, *conditions, **kwargs):

Diff for: pymc3/tests/test_dist_math.py

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2020 The PyMC Developers
1+
# Copyright 2021 The PyMC Developers
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -10,9 +10,6 @@
1010
# distributed under the License is distributed on an "AS IS" BASIS,
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
13-
# limitations under the License.
14-
import sys
15-
1613
import numpy as np
1714
import numpy.testing as npt
1815
import pytest
@@ -237,12 +234,7 @@ def test_grad(self):
237234
verify_grad(i0e, [[[0.5, -2.0]]])
238235

239236

240-
@pytest.mark.parametrize(
241-
"dtype",
242-
["float16", "float32", "float64", "float128"]
243-
if sys.platform != "win32"
244-
else ["float16", "float32", "float64"],
245-
)
237+
@pytest.mark.parametrize("dtype", ["float16", "float32", "float64"])
246238
def test_clipped_beta_rvs(dtype):
247239
# Verify that the samples drawn from the beta distribution are never
248240
# equal to zero or one (issue #3898)

0 commit comments

Comments
 (0)