-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add AePPL logp/logcdf references for all Distributions that are missing them #5329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These should probably use sphinx cross-references. I don't completely understand aeppl, it's scope and audience nor the relation pymc-aeppl, and I'm willing to be convinced otherwise in this scenario. IMO, there are two reasons for the comment above:
Note: Point 2 especially (but related to both) requires that aeppl has html documentation served somewhere. https://aesara-devs.github.io/aeppl/index.html exists but it seems to have last been updated on August. I can help (not do it myself) setting up documentation for aeppl, configuring readthedocs if that is something of interest to aesara-devs (cc @ricardoV94) and in fact I already reviewed aesara-devs/aeppl#52. If we can rely on aeppl having up to date documentation published then a link to relevant file in github is ok. |
Is it okay if I work on this? |
I think it's best to wait a bit on this until we figure out aeppl docs and how to better integrate the two documentations. I'm removing the labels for now. |
Description of your problem
Many of the distributions in PyMC call another library, AePPL, for their logp and logcdf calculation.
Please add references to the AePPL log P library. See PR below for an example of the code changes needed, and where to find the AePPL library
#5327
The text was updated successfully, but these errors were encountered: