Skip to content

Faling test_variational_inference.py::test_fit_fn_text #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue Sep 14, 2022 · 5 comments
Closed

Faling test_variational_inference.py::test_fit_fn_text #6127

ricardoV94 opened this issue Sep 14, 2022 · 5 comments
Labels
bug tests VI Variational Inference

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Sep 14, 2022 •
edited
Loading

This test failed a couple of times in #6113

test_variational_inference.py::test_fit_fn_text[asvgd-kwargs6-TypeError]

https://github.com/pymc-devs/pymc/actions/runs/3053220065/jobs/4923561777
@ricardoV94 ricardoV94 added tests needs info Additional information required VI Variational Inference labels Sep 14, 2022
@ricardoV94 ricardoV94 changed the title Faling test_variational_inference.py::test_fit_fn_text[asvgd-kwargs6-TypeError] Faling test_variational_inference.py::test_fit_fn_text Sep 14, 2022
@ricardoV94
Copy link
Member Author

CC @ferrine @fonnesbeck

@ricardoV94 ricardoV94 mentioned this issue Sep 14, 2022
Merged
5 tasks
@ricardoV94
Copy link
Member Author

Failed again in https://github.com/pymc-devs/pymc/actions/runs/3053791757/jobs/4924868962

@ricardoV94 ricardoV94 added the winOS windows OS related label Sep 14, 2022
@ricardoV94
Copy link
Member Author

Seems to fail on Windows only. It passes locally for me.

@Armavica
Copy link
Member

Armavica commented Sep 15, 2022 •
edited
Loading

It fails for me on linux on commit ec27b5c but not on commit bbb3082.

More precisely because the commits have been squashed, 1bd4fda is the first commit where the test fails.

Commenting out this line makes the test pass by me: 1bd4fda#diff-f159494798d11be8eb28b2085c0e5a306f99ed4fb61020cbc16e300a42b65944R637

@ricardoV94
Copy link
Member Author

I see the test was failing in the PR itself: https://github.com/pymc-devs/pymc/actions/runs/3003933042/jobs/4826249787.

I will revert it for the time being. CC @markusschmaus

@ricardoV94 ricardoV94 mentioned this issue Sep 15, 2022
Merged
@ricardoV94 ricardoV94 added bug and removed winOS windows OS related needs info Additional information required labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tests VI Variational Inference
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Armavica @ricardoV94