Skip to content

Stop squeezing stats by default #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelosthege opened this issue Oct 11, 2022 · 3 comments
Open

Stop squeezing stats by default #6207

michaelosthege opened this issue Oct 11, 2022 · 3 comments
Labels
major Include in major changes release notes section shape problem trace-backend Traces and ArviZ stuff

Comments

@michaelosthege
Copy link
Member

Squeezing stats by default removes the "stepmethod" dimension (which we don't name explicitly), but this does not always work for object-dtyped stats.

This is (very often) the case for the "warning" stat introduced by #6192, but also for stats that have varying shape.

We should probably not only stop squeezing, but instead unpack stats into a long form, such that there is not even a stepmeethod dimension.
This is how McBackend stores stats, because it works for any (hierarchical) combination of step methods.

@ricardoV94
Copy link
Member

ricardoV94 commented Dec 15, 2023

I think we have already done this, feel free to reopen if I am mistaken

@michaelosthege
Copy link
Member Author

No, it's still there:

return _squeeze_cat(results, combine, squeeze)

I was the last one to edit that file (7 months ago)

@ricardoV94
Copy link
Member

I was thinking of this 8ea8b3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Include in major changes release notes section shape problem trace-backend Traces and ArviZ stuff
Projects
None yet
Development

No branches or pull requests

2 participants