Skip to content

Only add dim_length shared variable when adding a new coordinate #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

lucianopaz
Copy link
Member

@lucianopaz lucianopaz commented Jun 3, 2025

Description

Only create a model's dim_length SharedVariable when adding a new coordinate.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7809.org.readthedocs.build/en/7809/

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (360cb6e) to head (8efaec4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7809   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         107      107           
  Lines       18380    18381    +1     
=======================================
+ Hits        17065    17066    +1     
  Misses       1315     1315           
Files with missing lines Coverage Δ
pymc/model/core.py 93.16% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucianopaz lucianopaz force-pushed the add_coord_multi_shared branch from e0431d6 to 8efaec4 Compare June 3, 2025 17:02
@lucianopaz lucianopaz merged commit c217727 into pymc-devs:main Jun 3, 2025
4 of 6 checks passed
@lucianopaz lucianopaz deleted the add_coord_multi_shared branch June 3, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Model.add_coord can add multiple SharedVariable dimension length with the same name
2 participants