Skip to content

plot issue with time-varying coefficient #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
esmailansari opened this issue May 19, 2025 · 1 comment · Fixed by #1698
Closed

plot issue with time-varying coefficient #1696

esmailansari opened this issue May 19, 2025 · 1 comment · Fixed by #1698
Labels
bug Something isn't working MMM plots

Comments

@esmailansari
Copy link
Contributor

esmailansari commented May 19, 2025 •
edited
Loading

Hi, I'm using time varying intercept in pymc-marketing, the intercept looks to be almost constant which is not correct but the intercept HDI varies with time which is correct (please see enclosed image). As shown in the image, the channel contribution line is within HDI and looks correct too. I found the fix and will push the fix in a pull request.

Image
@williambdean
Copy link
Contributor

Hi @esmailansari, thank you for reporting and willingness to open a PR. Please push even if it is a draft!

esmailansari pushed a commit to esmailansari/pymc-marketing that referenced this issue May 20, 2025
Issue pymc-labs#1696: addresses a bug in plotting the intercept for t…
af0a7e7 
…ime-varying-intercept
@esmailansari esmailansari mentioned this issue May 20, 2025
Merged
6 tasks
@williambdean williambdean added the bug Something isn't working label May 27, 2025
williambdean added a commit that referenced this issue May 27, 2025
@esmailansari @williambdean @pre-commit-ci
Issue #1696: addresses a bug in plotting the intercept (#1698)
1e9eeba 
* Issue #1696: addresses a bug in plotting the intercept for time-varying-intercept

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: esmail.ansari <[email protected]>
Co-authored-by: Will Dean <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MMM plots
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1696: addresses a bug in plotting the intercept esmailansari/pymc-marketing
2 participants
@esmailansari @williambdean