Skip to content

Commit fd06c22

Browse files
authored
Merge pull request #94 from lazka/fix-test-deprecations
tests: use loadTestsFromTestCase() instead of the deprecated makeSuite()
2 parents 3054764 + 9c4d48c commit fd06c22

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+44
-44
lines changed

distutils/tests/test_archive_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ def test_tarfile_root_owner(self):
387387
archive.close()
388388

389389
def test_suite():
390-
return unittest.makeSuite(ArchiveUtilTestCase)
390+
return unittest.TestLoader().loadTestsFromTestCase(ArchiveUtilTestCase)
391391

392392
if __name__ == "__main__":
393393
run_unittest(test_suite())

distutils/tests/test_bdist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_skip_build(self):
5151

5252

5353
def test_suite():
54-
return unittest.makeSuite(BuildTestCase)
54+
return unittest.TestLoader().loadTestsFromTestCase(BuildTestCase)
5555

5656
if __name__ == '__main__':
5757
run_unittest(test_suite())

distutils/tests/test_bdist_dumb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def test_simple_built(self):
9191
self.assertEqual(contents, sorted(wanted))
9292

9393
def test_suite():
94-
return unittest.makeSuite(BuildDumbTestCase)
94+
return unittest.TestLoader().loadTestsFromTestCase(BuildDumbTestCase)
9595

9696
if __name__ == '__main__':
9797
run_unittest(test_suite())

distutils/tests/test_bdist_msi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def test_minimal(self):
2222

2323

2424
def test_suite():
25-
return unittest.makeSuite(BDistMSITestCase)
25+
return unittest.TestLoader().loadTestsFromTestCase(BDistMSITestCase)
2626

2727
if __name__ == '__main__':
2828
run_unittest(test_suite())

distutils/tests/test_bdist_rpm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def test_no_optimize_flag(self):
129129
os.remove(os.path.join(pkg_dir, 'dist', 'foo-0.1-1.noarch.rpm'))
130130

131131
def test_suite():
132-
return unittest.makeSuite(BuildRpmTestCase)
132+
return unittest.TestLoader().loadTestsFromTestCase(BuildRpmTestCase)
133133

134134
if __name__ == '__main__':
135135
run_unittest(test_suite())

distutils/tests/test_bdist_wininst.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_get_exe_bytes(self):
3434
self.assertGreater(len(exe_file), 10)
3535

3636
def test_suite():
37-
return unittest.makeSuite(BuildWinInstTestCase)
37+
return unittest.TestLoader().loadTestsFromTestCase(BuildWinInstTestCase)
3838

3939
if __name__ == '__main__':
4040
run_unittest(test_suite())

distutils/tests/test_build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_finalize_options(self):
5050
self.assertEqual(cmd.executable, os.path.normpath(sys.executable))
5151

5252
def test_suite():
53-
return unittest.makeSuite(BuildTestCase)
53+
return unittest.TestLoader().loadTestsFromTestCase(BuildTestCase)
5454

5555
if __name__ == "__main__":
5656
run_unittest(test_suite())

distutils/tests/test_build_clib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def test_run(self):
130130
self.assertIn('libfoo.a', os.listdir(build_temp))
131131

132132
def test_suite():
133-
return unittest.makeSuite(BuildCLibTestCase)
133+
return unittest.TestLoader().loadTestsFromTestCase(BuildCLibTestCase)
134134

135135
if __name__ == "__main__":
136136
run_unittest(test_suite())

distutils/tests/test_build_ext.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,8 @@ def build_ext(self, *args, **kwargs):
538538

539539
def test_suite():
540540
suite = unittest.TestSuite()
541-
suite.addTest(unittest.makeSuite(BuildExtTestCase))
542-
suite.addTest(unittest.makeSuite(ParallelBuildExtTestCase))
541+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(BuildExtTestCase))
542+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(ParallelBuildExtTestCase))
543543
return suite
544544

545545
if __name__ == '__main__':

distutils/tests/test_build_py.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def test_dont_write_bytecode(self):
173173

174174

175175
def test_suite():
176-
return unittest.makeSuite(BuildPyTestCase)
176+
return unittest.TestLoader().loadTestsFromTestCase(BuildPyTestCase)
177177

178178
if __name__ == "__main__":
179179
run_unittest(test_suite())

distutils/tests/test_build_scripts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def test_version_int(self):
106106
self.assertIn(name, built)
107107

108108
def test_suite():
109-
return unittest.makeSuite(BuildScriptsTestCase)
109+
return unittest.TestLoader().loadTestsFromTestCase(BuildScriptsTestCase)
110110

111111
if __name__ == "__main__":
112112
run_unittest(test_suite())

distutils/tests/test_check.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def test_check_all(self):
157157
'restructuredtext': 1})
158158

159159
def test_suite():
160-
return unittest.makeSuite(CheckTestCase)
160+
return unittest.TestLoader().loadTestsFromTestCase(CheckTestCase)
161161

162162
if __name__ == "__main__":
163163
run_unittest(test_suite())

distutils/tests/test_clean.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def test_simple_run(self):
4343
cmd.run()
4444

4545
def test_suite():
46-
return unittest.makeSuite(cleanTestCase)
46+
return unittest.TestLoader().loadTestsFromTestCase(cleanTestCase)
4747

4848
if __name__ == "__main__":
4949
run_unittest(test_suite())

distutils/tests/test_cmd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def test_debug_print(self):
120120
debug.DEBUG = False
121121

122122
def test_suite():
123-
return unittest.makeSuite(CommandTestCase)
123+
return unittest.TestLoader().loadTestsFromTestCase(CommandTestCase)
124124

125125
if __name__ == '__main__':
126126
run_unittest(test_suite())

distutils/tests/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def test_config_interpolation(self):
135135

136136

137137
def test_suite():
138-
return unittest.makeSuite(PyPIRCCommandTestCase)
138+
return unittest.TestLoader().loadTestsFromTestCase(PyPIRCCommandTestCase)
139139

140140
if __name__ == "__main__":
141141
run_unittest(test_suite())

distutils/tests/test_config_cmd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def test_clean(self):
9292
self.assertFalse(os.path.exists(f))
9393

9494
def test_suite():
95-
return unittest.makeSuite(ConfigTestCase)
95+
return unittest.TestLoader().loadTestsFromTestCase(ConfigTestCase)
9696

9797
if __name__ == "__main__":
9898
run_unittest(test_suite())

distutils/tests/test_core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def test_debug_mode(self):
159159
self.assertEqual(stdout.readlines()[0], wanted)
160160

161161
def test_suite():
162-
return unittest.makeSuite(CoreTestCase)
162+
return unittest.TestLoader().loadTestsFromTestCase(CoreTestCase)
163163

164164
if __name__ == "__main__":
165165
run_unittest(test_suite())

distutils/tests/test_cygwinccompiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def test_get_msvcr(self):
9090
self.assertRaises(ValueError, get_msvcr)
9191

9292
def test_suite():
93-
return unittest.makeSuite(CygwinCCompilerTestCase)
93+
return unittest.TestLoader().loadTestsFromTestCase(CygwinCCompilerTestCase)
9494

9595
if __name__ == '__main__':
9696
run_unittest(test_suite())

distutils/tests/test_dep_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def test_newer_group(self):
7474

7575

7676
def test_suite():
77-
return unittest.makeSuite(DepUtilTestCase)
77+
return unittest.TestLoader().loadTestsFromTestCase(DepUtilTestCase)
7878

7979
if __name__ == "__main__":
8080
run_unittest(test_suite())

distutils/tests/test_dir_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def test_copy_tree_exception_in_listdir(self):
133133

134134

135135
def test_suite():
136-
return unittest.makeSuite(DirUtilTestCase)
136+
return unittest.TestLoader().loadTestsFromTestCase(DirUtilTestCase)
137137

138138
if __name__ == "__main__":
139139
run_unittest(test_suite())

distutils/tests/test_dist.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,8 +525,8 @@ def test_read_metadata(self):
525525

526526
def test_suite():
527527
suite = unittest.TestSuite()
528-
suite.addTest(unittest.makeSuite(DistributionTestCase))
529-
suite.addTest(unittest.makeSuite(MetadataTestCase))
528+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(DistributionTestCase))
529+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(MetadataTestCase))
530530
return suite
531531

532532
if __name__ == "__main__":

distutils/tests/test_extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_extension_init(self):
6565
"Unknown Extension options: 'chic'")
6666

6767
def test_suite():
68-
return unittest.makeSuite(ExtensionTestCase)
68+
return unittest.TestLoader().loadTestsFromTestCase(ExtensionTestCase)
6969

7070
if __name__ == "__main__":
7171
run_unittest(test_suite())

distutils/tests/test_file_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_copy_file_hard_link_failure(self):
118118

119119

120120
def test_suite():
121-
return unittest.makeSuite(FileUtilTestCase)
121+
return unittest.TestLoader().loadTestsFromTestCase(FileUtilTestCase)
122122

123123
if __name__ == "__main__":
124124
run_unittest(test_suite())

distutils/tests/test_filelist.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,8 +344,8 @@ def test_symlink_loop(self):
344344

345345
def test_suite():
346346
return unittest.TestSuite([
347-
unittest.makeSuite(FileListTestCase),
348-
unittest.makeSuite(FindAllTestCase),
347+
unittest.TestLoader().loadTestsFromTestCase(FileListTestCase),
348+
unittest.TestLoader().loadTestsFromTestCase(FindAllTestCase),
349349
])
350350

351351

distutils/tests/test_install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def test_debug_mode(self):
244244

245245

246246
def test_suite():
247-
return unittest.makeSuite(InstallTestCase)
247+
return unittest.TestLoader().loadTestsFromTestCase(InstallTestCase)
248248

249249
if __name__ == "__main__":
250250
run_unittest(test_suite())

distutils/tests/test_install_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def test_simple_run(self):
6969
self.assertTrue(os.path.exists(os.path.join(inst, rone)))
7070

7171
def test_suite():
72-
return unittest.makeSuite(InstallDataTestCase)
72+
return unittest.TestLoader().loadTestsFromTestCase(InstallDataTestCase)
7373

7474
if __name__ == "__main__":
7575
run_unittest(test_suite())

distutils/tests/test_install_headers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def test_simple_run(self):
3333
self.assertEqual(len(cmd.get_outputs()), 2)
3434

3535
def test_suite():
36-
return unittest.makeSuite(InstallHeadersTestCase)
36+
return unittest.TestLoader().loadTestsFromTestCase(InstallHeadersTestCase)
3737

3838
if __name__ == "__main__":
3939
run_unittest(test_suite())

distutils/tests/test_install_lib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def test_dont_write_bytecode(self):
109109

110110

111111
def test_suite():
112-
return unittest.makeSuite(InstallLibTestCase)
112+
return unittest.TestLoader().loadTestsFromTestCase(InstallLibTestCase)
113113

114114
if __name__ == "__main__":
115115
run_unittest(test_suite())

distutils/tests/test_install_scripts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def write_script(name, text):
7676

7777

7878
def test_suite():
79-
return unittest.makeSuite(InstallScriptsTestCase)
79+
return unittest.TestLoader().loadTestsFromTestCase(InstallScriptsTestCase)
8080

8181
if __name__ == "__main__":
8282
run_unittest(test_suite())

distutils/tests/test_log.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def test_non_ascii(self):
4040
'Fαtal\t\\xc8rr\\u014dr')
4141

4242
def test_suite():
43-
return unittest.makeSuite(TestLog)
43+
return unittest.TestLoader().loadTestsFromTestCase(TestLog)
4444

4545
if __name__ == "__main__":
4646
run_unittest(test_suite())

distutils/tests/test_msvc9compiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def test_remove_entire_manifest(self):
178178

179179

180180
def test_suite():
181-
return unittest.makeSuite(msvc9compilerTestCase)
181+
return unittest.TestLoader().loadTestsFromTestCase(msvc9compilerTestCase)
182182

183183
if __name__ == "__main__":
184184
run_unittest(test_suite())

distutils/tests/test_msvccompiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def CCompiler_spawn(self, cmd):
132132

133133

134134
def test_suite():
135-
return unittest.makeSuite(msvccompilerTestCase)
135+
return unittest.TestLoader().loadTestsFromTestCase(msvccompilerTestCase)
136136

137137
if __name__ == "__main__":
138138
run_unittest(test_suite())

distutils/tests/test_register.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ def test_show_response(self):
319319

320320

321321
def test_suite():
322-
return unittest.makeSuite(RegisterTestCase)
322+
return unittest.TestLoader().loadTestsFromTestCase(RegisterTestCase)
323323

324324
if __name__ == "__main__":
325325
run_unittest(test_suite())

distutils/tests/test_sdist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ def test_make_distribution_owner_group(self):
483483
archive.close()
484484

485485
def test_suite():
486-
return unittest.makeSuite(SDistTestCase)
486+
return unittest.TestLoader().loadTestsFromTestCase(SDistTestCase)
487487

488488
if __name__ == "__main__":
489489
run_unittest(test_suite())

distutils/tests/test_spawn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def test_spawn_missing_exe(self):
133133

134134

135135
def test_suite():
136-
return unittest.makeSuite(SpawnTestCase)
136+
return unittest.TestLoader().loadTestsFromTestCase(SpawnTestCase)
137137

138138
if __name__ == "__main__":
139139
run_unittest(test_suite())

distutils/tests/test_sysconfig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ def test_parse_config_h(self):
295295

296296
def test_suite():
297297
suite = unittest.TestSuite()
298-
suite.addTest(unittest.makeSuite(SysconfigTestCase))
298+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(SysconfigTestCase))
299299
return suite
300300

301301

distutils/tests/test_text_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def test_input(count, description, file, expected_result):
101101
in_file.close()
102102

103103
def test_suite():
104-
return unittest.makeSuite(TextFileTestCase)
104+
return unittest.TestLoader().loadTestsFromTestCase(TextFileTestCase)
105105

106106
if __name__ == "__main__":
107107
run_unittest(test_suite())

distutils/tests/test_unixccompiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def test_has_function(self):
246246

247247

248248
def test_suite():
249-
return unittest.makeSuite(UnixCCompilerTestCase)
249+
return unittest.TestLoader().loadTestsFromTestCase(UnixCCompilerTestCase)
250250

251251
if __name__ == "__main__":
252252
run_unittest(test_suite())

distutils/tests/test_upload.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def test_wrong_exception_order(self):
217217

218218

219219
def test_suite():
220-
return unittest.makeSuite(uploadTestCase)
220+
return unittest.TestLoader().loadTestsFromTestCase(uploadTestCase)
221221

222222
if __name__ == "__main__":
223223
run_unittest(test_suite())

distutils/tests/test_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ def test_grok_environment_error(self):
303303

304304

305305
def test_suite():
306-
return unittest.makeSuite(UtilTestCase)
306+
return unittest.TestLoader().loadTestsFromTestCase(UtilTestCase)
307307

308308
if __name__ == "__main__":
309309
run_unittest(test_suite())

distutils/tests/test_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def test_cmp(self):
8989
(v1, v2, res))
9090

9191
def test_suite():
92-
return unittest.makeSuite(VersionTestCase)
92+
return unittest.TestLoader().loadTestsFromTestCase(VersionTestCase)
9393

9494
if __name__ == "__main__":
9595
run_unittest(test_suite())

0 commit comments

Comments
 (0)