Skip to content

Optional dependencies not handled in migration script #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blink1073 opened this issue May 14, 2022 · 5 comments · Fixed by #260
Closed

Optional dependencies not handled in migration script #241

blink1073 opened this issue May 14, 2022 · 5 comments · Fixed by #260

Comments

@blink1073
Copy link
Contributor

Seen while working on jupyter/notebook#6425 and running hatch new --init.

It might have been because we were using [options.extras_require] in setup.cfg and not in setup.py
@blink1073
Copy link
Contributor Author

Would you accept a PR that handles both this case and converting data_files to equivalent shared-data config? As I said in #259 , I'm trying to ease the transition for Jupyter extension authors.

@ofek ofek mentioned this issue May 22, 2022
Merged
@ofek
Copy link
Collaborator

ofek commented May 22, 2022

Ha literally just opened #260

I'll add that too

@blink1073
Copy link
Contributor Author

Haha good timing. Thank you!

@ofek
Copy link
Collaborator

ofek commented May 22, 2022

Hmm, jupyter_packaging uses some setuptools stuff which breaks the shim. Lemme try some hacks...

@ofek
Copy link
Collaborator

ofek commented May 22, 2022

Success! 261ea89

@ofek ofek closed this as completed in #260 May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve setuptools migration script pypa/hatch
2 participants
@blink1073 @ofek