Surface LegacyVersion and LegacySpecifier deprecation warnings

Author: sbidoul

news/12063.removal.rst

@@ -0,0 +1,2 @@
+Deprecate legacy version and version specifiers that don't conform to `PEP 440
+<https://peps.python.org/pep-0440/>`_

src/pip/_vendor/packaging/specifiers.py

@@ -252,15 +252,18 @@ class LegacySpecifier(_IndividualSpecifier):
     def __init__(self, spec: str = "", prereleases: Optional[bool] = None) -> None:
         super().__init__(spec, prereleases)
 
-        warnings.warn(
-            "Creating a LegacyVersion has been deprecated and will be "
-            "removed in the next major release",
-            DeprecationWarning,
+        from pip._internal.utils.deprecation import deprecated
+
+        deprecated(
+            reason=(f"This form of version specifier ({spec}) has been deprecated."),
+            replacement="use PEP 440 compatible version specifiers",
+            gone_in="23.3",
+            issue=12063,
         )
 
     def _coerce_version(self, version: UnparsedVersion) -> LegacyVersion:
         if not isinstance(version, LegacyVersion):
-            version = LegacyVersion(str(version))
+            version = LegacyVersion(str(version), silence_deprecation_warning=True)
         return version
 
     def _compare_equal(self, prospective: LegacyVersion, spec: str) -> bool:

src/pip/_vendor/packaging/version.py

@@ -104,15 +104,23 @@ def __ne__(self, other: object) -> bool:
 
 
 class LegacyVersion(_BaseVersion):
-    def __init__(self, version: str) -> None:
+    def __init__(
+        self,
+        version: str,
+        silence_deprecation_warning: bool = False,
+    ) -> None:
         self._version = str(version)
         self._key = _legacy_cmpkey(self._version)
 
-        warnings.warn(
-            "Creating a LegacyVersion has been deprecated and will be "
-            "removed in the next major release",
-            DeprecationWarning,
-        )
+        if not silence_deprecation_warning:
+            from pip._internal.utils.deprecation import deprecated
+
+            deprecated(
+                reason=(f"This form of version ({version}) has been deprecated."),
+                replacement="use PEP 440 compatible versions",
+                gone_in="23.3",
+                issue=12063,
+            )
 
     def __str__(self) -> str:
         return self._version

tools/vendoring/patches/packaging.patch

@@ -0,0 +1,70 @@
+Surface LegacyVersion and LegacySpecifier deprecation warnings
+as pip deprecation warnings.
+
+---
+ src/pip/_vendor/packaging/specifiers.py | 12 +++++++-----
+ src/pip/_vendor/packaging/version.py    | 19 +++++++++++++------
+ 2 files changed, 20 insertions(+), 11 deletions(-)
+
+diff --git a/src/pip/_vendor/packaging/specifiers.py b/src/pip/_vendor/packaging/specifiers.py
+index 0e218a6f9f7..b0a1cee288b 100644
+--- a/src/pip/_vendor/packaging/specifiers.py
++++ b/src/pip/_vendor/packaging/specifiers.py
+@@ -252,15 +252,18 @@ class LegacySpecifier(_IndividualSpecifier):
+     def __init__(self, spec: str = "", prereleases: Optional[bool] = None) -> None:
+         super().__init__(spec, prereleases)
+ 
+-        warnings.warn(
+-            "Creating a LegacyVersion has been deprecated and will be "
+-            "removed in the next major release",
+-            DeprecationWarning,
++        from pip._internal.utils.deprecation import deprecated
++
++        deprecated(
++            reason=(f"This form of version specifier ({spec}) has been deprecated."),
++            replacement="use PEP 440 compatible version specifiers",
++            gone_in="23.3",
++            issue=12063,
+         )
+ 
+     def _coerce_version(self, version: UnparsedVersion) -> LegacyVersion:
+         if not isinstance(version, LegacyVersion):
+-            version = LegacyVersion(str(version))
++            version = LegacyVersion(str(version), silence_deprecation_warning=True)
+         return version
+ 
+     def _compare_equal(self, prospective: LegacyVersion, spec: str) -> bool:
+diff --git a/src/pip/_vendor/packaging/version.py b/src/pip/_vendor/packaging/version.py
+index de9a09a4ed3..cc68ed67424 100644
+--- a/src/pip/_vendor/packaging/version.py
++++ b/src/pip/_vendor/packaging/version.py
+@@ -104,15 +104,23 @@ def __ne__(self, other: object) -> bool:
+ 
+ 
+ class LegacyVersion(_BaseVersion):
+-    def __init__(self, version: str) -> None:
++    def __init__(
++        self,
++        version: str,
++        silence_deprecation_warning: bool = False,
++    ) -> None:
+         self._version = str(version)
+         self._key = _legacy_cmpkey(self._version)
+ 
+-        warnings.warn(
+-            "Creating a LegacyVersion has been deprecated and will be "
+-            "removed in the next major release",
+-            DeprecationWarning,
+-        )
++        if not silence_deprecation_warning:
++            from pip._internal.utils.deprecation import deprecated
++
++            deprecated(
++                reason=(f"This form of version ({version}) has been deprecated."),
++                replacement="use PEP 440 compatible versions",
++                gone_in="23.3",
++                issue=12063,
++            )
+ 
+     def __str__(self) -> str:
+         return self._version