update log message

Author: ronaudinho

src/pip/_internal/index/package_finder.py

@@ -223,7 +223,7 @@ def evaluate_link(self, link: Link) -> Tuple[bool, Optional[str]]:
             ignore_requires_python=self._ignore_requires_python,
         )
         if not supports_python:
-            reason = f'{version} Requires-Python {link.requires_python}'
+            reason = f"{version} Requires-Python {link.requires_python}"
             return (False, reason)
 
         logger.debug("Found link %s, version: %s", link, version)
@@ -685,6 +685,11 @@ def prefer_binary(self) -> bool:
     def set_prefer_binary(self) -> None:
         self._candidate_prefs.prefer_binary = True
 
+    def skipped_links_requires_python(self) -> List[str]:
+        return sorted(
+            {reason for _, reason in self._logged_links if "Requires-Python" in reason}
+        )
+
     def make_link_evaluator(self, project_name: str) -> LinkEvaluator:
         canonical_name = canonicalize_name(project_name)
         formats = self.format_control.get_allowed_formats(canonical_name)
@@ -698,18 +703,6 @@ def make_link_evaluator(self, project_name: str) -> LinkEvaluator:
             ignore_requires_python=self._ignore_requires_python,
         )
 
-    def skipped_links_requires_python(self):
-        # type: () -> List[str]
-        return sorted(
-            {reason for _, reason in self._logged_links if 'Requires-Python' in reason}
-        )
-
-    def logged_links_rp(self):
-        # type: () -> List[str]
-        skips = [skip for skip in self._logged_links_rp]
-        skips.sort()
-        return skips
-
     def _sort_links(self, links: Iterable[Link]) -> List[Link]:
         """
         Returns elements of links in order, non-egg links first, egg links
@@ -730,7 +723,7 @@ def _log_skipped_link(self, link: Link, reason: str) -> None:
         if (link, reason) not in self._logged_links:
             # Put the link at the end so the reason is more visible and because
             # the link string is usually very long.
-            logger.debug('Skipping link: %s: %s', reason, link)
+            logger.debug("Skipping link: %s: %s", reason, link)
             self._logged_links.add((link, reason))
 
     def get_install_candidate(
@@ -751,11 +744,6 @@ def get_install_candidate(
             version=result,
         )
 
-    def _log_skipped_link_rp(self, reason):
-        # type: (str) -> None
-        if reason not in self._logged_links_rp:
-            self._logged_links_rp.add(reason)
-
     def evaluate_links(
         self, link_evaluator: LinkEvaluator, links: Iterable[Link]
     ) -> List[InstallationCandidate]:

src/pip/_internal/resolution/resolvelib/factory.py

@@ -582,6 +582,12 @@ def _report_single_requirement_conflict(
         skips = self._finder.skipped_links_requires_python()
         versions = [str(v) for v in sorted({c.version for c in cands})]
 
+        if skips:
+            logger.critical(
+                "Ignored the following versions that require a different python "
+                "version: %s",
+                "; ".join(skips) or "none",
+            )
         logger.critical(
             "Could not find a version that satisfies the requirement %s "
             "(from versions: %s)",
@@ -595,12 +601,6 @@ def _report_single_requirement_conflict(
                 "using the '-r' flag to install the packages listed in "
                 "requirements.txt"
             )
-        logger.critical(
-            "Found versions that do not satisfy the requirement %s "
-            "(from versions: %s)",
-            req_disp,
-            ", ".join(skips) or "none",
-        )
 
         return DistributionNotFound(f"No matching distribution found for {req}")
 

tests/unit/test_index.py

@@ -114,7 +114,7 @@ class TestLinkEvaluator:
         [
             ((3, 6, 5), None, (True, "1.12")),
             # Test an incompatible Python.
-            ((3, 6, 4), None, (False, '1.12 Requires-Python == 3.6.5')),
+            ((3, 6, 4), None, (False, "1.12 Requires-Python == 3.6.5")),
             # Test an incompatible Python with ignore_requires_python=True.
             ((3, 6, 4), True, (True, "1.12")),
         ],