Skip to content

Commit 528a193

Browse files
committed
Fix incorrect comment in tests
1 parent 9360793 commit 528a193

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

news/22476270-1CF0-4D00-8621-E633D06AA53A.trivial

Whitespace-only changes.

tests/functional/test_install.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -1855,15 +1855,16 @@ def test_install_skip_work_dir_pkg(script, data):
18551855
and an uninstall
18561856
"""
18571857

1858-
# Create a test package and install it
1858+
# Create a test package, install it and then uninstall it
18591859
pkg_path = create_test_package_with_setup(
18601860
script, name='simple', version='1.0')
18611861
script.pip('install', '-e', '.',
18621862
expect_stderr=True, cwd=pkg_path)
18631863

1864-
# Uninstalling the package and installing it again will succeed
18651864
script.pip('uninstall', 'simple', '-y')
18661865

1866+
# Running the install command again from the working directory
1867+
# will install the package as it was uninstalled earlier
18671868
result = script.pip('install', '--find-links',
18681869
data.find_links, 'simple',
18691870
expect_stderr=True, cwd=pkg_path)
@@ -1879,19 +1880,18 @@ def test_install_include_work_dir_pkg(script, data):
18791880
if working directory is added in PYTHONPATH
18801881
"""
18811882

1882-
# Create a test package and install it
1883+
# Create a test package, install it and then uninstall it
18831884
pkg_path = create_test_package_with_setup(
18841885
script, name='simple', version='1.0')
18851886
script.pip('install', '-e', '.',
18861887
expect_stderr=True, cwd=pkg_path)
1887-
1888-
# Uninstall will fail with given warning
18891888
script.pip('uninstall', 'simple', '-y')
18901889

18911890
script.environ.update({'PYTHONPATH': pkg_path})
18921891

1893-
# Uninstalling the package and installing it again will fail,
1894-
# when package directory is in PYTHONPATH
1892+
# Running the install command again from the working directory
1893+
# will be a no-op, as the package is found to be installed,
1894+
# when the package directory is in PYTHONPATH
18951895
result = script.pip('install', '--find-links',
18961896
data.find_links, 'simple',
18971897
expect_stderr=True, cwd=pkg_path)

tests/functional/test_list.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -575,10 +575,10 @@ def test_list_include_work_dir_pkg(script):
575575
script.run('python', 'setup.py', 'egg_info',
576576
expect_stderr=True, cwd=pkg_path)
577577

578-
# Add PYTHONPATH env variable
579578
script.environ.update({'PYTHONPATH': pkg_path})
580579

581580
# List should include package simple when run from package directory
581+
# when the package directory is in PYTHONPATH
582582
result = script.pip('list', '--format=json', cwd=pkg_path)
583583
json_result = json.loads(result.stdout)
584584
assert {'name': 'simple', 'version': '1.0'} in json_result

0 commit comments

Comments
 (0)