Skip to content

Commit 59f2206

Browse files
committed
Move Downloader construction to RequirementPreparer.__init__
Just one step away from pulling this out of operations.prepare altogether.
1 parent 3c8be92 commit 59f2206

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/pip/_internal/operations/prepare.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ def __init__(
558558
self.src_dir = src_dir
559559
self.build_dir = build_dir
560560
self.req_tracker = req_tracker
561-
self.session = session
561+
self.downloader = Downloader(session, progress_bar)
562562
self.finder = finder
563563

564564
# Where still-packed archives should be written to. If None, they are
@@ -579,8 +579,6 @@ def __init__(
579579
# be combined if we're willing to have non-wheel archives present in
580580
# the wheelhouse output by 'pip wheel'.
581581

582-
self.progress_bar = progress_bar
583-
584582
# Is build isolation allowed?
585583
self.build_isolation = build_isolation
586584

@@ -680,11 +678,9 @@ def prepare_linked_requirement(
680678
# dedicated dir.
681679
download_dir = self.wheel_download_dir
682680

683-
downloader = Downloader(self.session, self.progress_bar)
684-
685681
try:
686682
unpack_url(
687-
link, req.source_dir, downloader, download_dir,
683+
link, req.source_dir, self.downloader, download_dir,
688684
hashes=hashes,
689685
)
690686
except requests.HTTPError as exc:

0 commit comments

Comments
 (0)