Skip to content

Commit 623ac5d

Browse files
committed
Do fallback but issue a warning
1 parent 14a3d93 commit 623ac5d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/pip/_internal/network/auth.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,12 @@ def get_keyring_provider() -> KeyRingBaseProvider:
154154
pass
155155
except Exception as exc:
156156
# In the event of an unexpected exception
157-
# we shouldn't fallback silently to the
158-
# CliProvider
157+
# we should warn the user
159158
logger.warning(
160-
"Keyring is skipped due to an exception: %s",
159+
"Installed copy of keyring fails with exception %s, "
160+
"trying to find a keyring executable as a fallback",
161161
str(exc),
162162
)
163-
return KeyRingNullProvider()
164163

165164
# Fallback to Cli Provider if `keyring` isn't installed
166165
cli = shutil.which("keyring")

0 commit comments

Comments
 (0)